[edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code coverage tool

[Guo, Gua]

In parallel, I’ve sent the PR Install lcov in all linux based image by gguo11837463 * Pull Request #70 * tianocore/containers (github.com)<https://github.com/tianocore/containers/pull/70>  to https://github.com/tianocore/containers, if the PR looks good and deploy into latest images that can be used by latest Edk2 azurepipeline. I can revert commit “ba3afb0d474241e26442dd4ccf45c81d03a4c50e” on the PR https://github.com/tianocore/edk2/pull/4300.

Thanks,
Gua
From: Guo, Gua <gua.guo at intel.com>
Sent: Sunday, April 23, 2023 4:44 PM
To: devel at edk2.groups.io; Kinney, Michael D <michael.d.kinney at intel.com>; fernald, chris <chfernal at microsoft.com>
Cc: Sean Brogan <sean.brogan at microsoft.com>; Michael Kubacki <mikuback at linux.microsoft.com>; Oliver Steffen <osteffen at redhat.com>; Kinney, Michael D <michael.d.kinney at intel.com>
Subject: Re: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code coverage tool

I know maybe I need to update https://github.com/tianocore/containers but add these step, i f have any guidelines for me that will be great.


________________________________
寄件者: 「devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>>」代表「Sean <spbrogan at outlook.com<mailto:spbrogan at outlook.com>>」
寄件日期: 2023年4月23日 星期日 下午2:13
收件者: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>>; Kinney, Michael D <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>; Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>; fernald, chris <chfernal at microsoft.com<mailto:chfernal at microsoft.com>>
副本: Sean Brogan <sean.brogan at microsoft.com<mailto:sean.brogan at microsoft.com>>; Michael Kubacki <mikuback at linux.microsoft.com<mailto:mikuback at linux.microsoft.com>>; Oliver Steffen <osteffen at redhat.com<mailto:osteffen at redhat.com>>; Kinney, Michael D <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>
主旨: Re: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code coverage tool

Sorry a little late to review this. It looks like these are container based builds. If that is the case we should handle this by updating the container. The whole point of the container is to get the requirements all included in the container. @Chris Fernald<mailto:chfernal at microsoft.com> can you share details.

Thanks
Sean
________________________________
From: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>> on behalf of Michael D Kinney <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>
Sent: Saturday, April 22, 2023 8:15:56 PM
To: Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>>
Cc: Sean Brogan <sean.brogan at microsoft.com<mailto:sean.brogan at microsoft.com>>; Michael Kubacki <mikuback at linux.microsoft.com<mailto:mikuback at linux.microsoft.com>>; Oliver Steffen <osteffen at redhat.com<mailto:osteffen at redhat.com>>; Kinney, Michael D <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>
Subject: Re: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code coverage tool

Reviewed-by: Michael D Kinney <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>

> -----Original Message-----
> From: Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>
> Sent: Saturday, April 22, 2023 6:22 PM
> To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>
> Cc: Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>; Kinney, Michael D <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>; Sean Brogan <sean.brogan at microsoft.com<mailto:sean.brogan at microsoft.com>>;
> Michael Kubacki <mikuback at linux.microsoft.com<mailto:mikuback at linux.microsoft.com>>; Oliver Steffen <osteffen at redhat.com<mailto:osteffen at redhat.com>>
> Subject: [PATCH v2 2/2] .azurepipelines: Install code coverage tool
>
> From: Gua Guo <gua.guo at intel.com<mailto:gua.guo at intel.com>>
>
> Azure should install code coverage tool (lcov), it didn't
> exist on Fedora and Ubuntu by default.
>
> Cc: Michael D Kinney <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>
> Cc: Sean Brogan <sean.brogan at microsoft.com<mailto:sean.brogan at microsoft.com>>
> Cc: Michael Kubacki <mikuback at linux.microsoft.com<mailto:mikuback at linux.microsoft.com>>
> Cc: Oliver Steffen <osteffen at redhat.com<mailto:osteffen at redhat.com>>
> Signed-off-by: Gua Guo <gua.guo at intel.com<mailto:gua.guo at intel.com>>
> ---
>  .azurepipelines/Ubuntu-GCC5.yml | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/.azurepipelines/Ubuntu-GCC5.yml b/.azurepipelines/Ubuntu-GCC5.yml
> index b9a3b851cf..d884256148 100644
> --- a/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/.azurepipelines/Ubuntu-GCC5.yml
> @@ -24,3 +24,7 @@ jobs:
>      container: ${{ variables.default_linux_image }}
>
>      arch_list: "IA32,X64,ARM,AARCH64,RISCV64,LOONGARCH64"
>
>      usePythonVersion: ''  # use Python from the container image
>
> +    extra_install_step:
>
> +    - bash: sudo dnf install -y lcov
>
> +      displayName: Install Code Coverage Tools
>
> +      condition: and(gt(variables.pkg_count, 0), succeeded())
>
> --
> 2.39.2.windows.1









-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103454): https://edk2.groups.io/g/devel/message/103454
Mute This Topic: https://groups.io/mt/98443857/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20230424/98af9a24/attachment-0001.htm>