[edk2-devel] [Patch V2 1/2] UefiCpuPkg: Update code to support enable ProcTrace only on BSP

[duntan]

Thanks for the comments. I'll add comments to explain it.

Thanks,
Dun

-----Original Message-----
From: Ni, Ray <ray.ni at intel.com> 
Sent: Tuesday, April 25, 2023 10:10 PM
To: devel at edk2.groups.io; Tan, Dun <dun.tan at intel.com>
Cc: Dong, Eric <eric.dong at intel.com>; Kumar, Rahul R <rahul.r.kumar at intel.com>; Gerd Hoffmann <kraxel at redhat.com>; Chen, Xiao X <xiao.x.chen at intel.com>
Subject: RE: [edk2-devel] [Patch V2 1/2] UefiCpuPkg: Update code to support enable ProcTrace only on BSP

> +    if (ProcTraceData->EnableOnBspOnly) {

1. can you please add comments here to remind reader that
    this is also the first and only time ProcTraceInitialize() runs?
    Similar comments in the next chunk code.

> +      MemRegionBaseAddr = (UINTN)AllocateAlignedReservedPages (Pages,
> Alignment);
> +      if (MemRegionBaseAddr == 0) {
> +        //
> +        // Could not allocate for BSP even
> +        //
> +        DEBUG ((DEBUG_ERROR, "ProcTrace: Out of mem, failed to allocate
> buffer for BSP\n"));
> +        return RETURN_OUT_OF_RESOURCES;
> +      } 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103604): https://edk2.groups.io/g/devel/message/103604
Mute This Topic: https://groups.io/mt/98489089/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-