[edk2-devel] [PATCH v2 2/2] .azurepipelines: Choose container that have installed lcov

[Guo, Gua]

Sure, I will update the commit message.
________________________________
From: Kinney, Michael D <michael.d.kinney at intel.com>
Sent: Thursday, April 27, 2023 8:52:40 AM
To: Guo, Gua <gua.guo at intel.com>; devel at edk2.groups.io <devel at edk2.groups.io>
Cc: Sean Brogan <sean.brogan at microsoft.com>; Michael Kubacki <mikuback at linux.microsoft.com>; Oliver Steffen <osteffen at redhat.com>; fernald, chris <chfernal at microsoft.com>; Kinney, Michael D <michael.d.kinney at intel.com>
Subject: RE: [PATCH v2 2/2] .azurepipelines: Choose container that have installed lcov

Hi Gua,

It is hard to review this type of patch without more context.

Can you provide a link to the PR or branch where the docker image was updated?  That information should be part of the commit message.

Thanks,

Mike

> -----Original Message-----
> From: Guo, Gua <gua.guo at intel.com>
> Sent: Wednesday, April 26, 2023 5:34 PM
> To: devel at edk2.groups.io
> Cc: Guo, Gua <gua.guo at intel.com>; Kinney, Michael D
> <michael.d.kinney at intel.com>; Sean Brogan <sean.brogan at microsoft.com>;
> Michael Kubacki <mikuback at linux.microsoft.com>; Oliver Steffen
> <osteffen at redhat.com>; fernald, chris <chfernal at microsoft.com>
> Subject: [PATCH v2 2/2] .azurepipelines: Choose container that have installed
> lcov
>
> From: Gua Guo <gua.guo at intel.com>
>
> Azure should install code coverage tool (lcov), it didn't
> exist on Fedora and Ubuntu by default.
>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Cc: Sean Brogan <sean.brogan at microsoft.com>
> Cc: Michael Kubacki <mikuback at linux.microsoft.com>
> Cc: Oliver Steffen <osteffen at redhat.com>
> Cc: Chris Fernald <chfernal at microsoft.com>
> Signed-off-by: Gua Guo <gua.guo at intel.com>
> ---
>  .azurepipelines/templates/defaults.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.azurepipelines/templates/defaults.yml
> b/.azurepipelines/templates/defaults.yml
> index 74d6b41783..8412a43cad 100644
> --- a/.azurepipelines/templates/defaults.yml
> +++ b/.azurepipelines/templates/defaults.yml
> @@ -9,4 +9,4 @@
>
>
>  variables:
>
>    default_python_version: ">=3.10.6"
>
> -  default_linux_image: "ghcr.io/tianocore/containers/fedora-35-test:47addc9"
>
> +  default_linux_image: "ghcr.io/tianocore/containers/fedora-35-test:3b3eb8f"
>
> --
> 2.39.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103678): https://edk2.groups.io/g/devel/message/103678
Mute This Topic: https://groups.io/mt/98527916/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20230427/f274b785/attachment-0001.htm>