[edk2-devel] [PATCH v2 3/4] DynamicTablesPkg: Add support to add Strings to package

[Sami Mujawar]

Hi Jeff,

Thank you for this patch.
Please see my response inline.

On Mon, Jul 10, 2023 at 03:26 PM, Jeff Brasen wrote:

> 
> +
> + Status = AmlVarListAddTail (
> + (AML_NODE_HANDLE)PackageNode,
> + (AML_NODE_HANDLE)DataNode
> + );
> + ASSERT_EFI_ERROR (Status);
> +

I think if the above function fails DataNode would need to be freed as it is not linked in the AML tree. Can you check, please?

With that addressed,

Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107630): https://edk2.groups.io/g/devel/message/107630
Mute This Topic: https://groups.io/mt/100068078/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20230807/4b43df8c/attachment-0001.htm>