[edk2-devel] edk2setup.sh shortcomings

[tlaronde at polynum.com]

edk2setup.sh has shortcomings. To list some:

	- The functions return a status but it is not tested; hence the
	  script goes to the end with a final "return $?" that simply
	  returns the status of the last command that is "unset" which
	  always successfully unsets, even a not set variable. Hence a
	  script can not catch a failure by testing the end status that is
	  always 0;
	- If WORKSPACE is set, --reconfig does nothing;
	- If EDK_TOOLS_PATH and PACKAGES_PATH are set, even to incorrect
	  values, the script succeeds even if BaseTools/ is not found
	  anywhere;
	- The comments are obsolete (1): bash(1) is required because the syntax
	  is not POSIX.2 sh(1) compliant and because some Makefile recipes
	  have "bash'isms" (indeed, a GMAKE variable should be exported
	  with a definition of "/path/to/gnu/make SHELL=/path/to/bash" and
	  a canonical call should be "$GMAKE ...");
	- The comments are obsolete (2): CYGWIN is not treated in anyway
	  specifically and, on the contrary, the regexp translation of ':'
	  in spaces for PACKAGES_PATH would be sure to create a mess with
	  a MS Windows like path;
 	- The settings have obviously evolved and the help message does not
	  list all the variables that can be set and that do modify the
	  way the setting is done;
	- Some commands (notably whereis(1)) are not standard utilities, not
	  to be found on all Unix like systems and, even if found, have
	  greatly diverging behaviors.

What is the preferred procedure? Should I file BZ to list all the
problems so that someone authorized may address them? Or can I propose
a patch to address these (keeping it backward compatible with a present
correct use) with a reasonable hope that, as an exception that will not
become a rule, it will not be ignored?

Best,
-- 
        Thierry Laronde <tlaronde +AT+ polynum +dot+ com>
                     http://www.kergis.com/
                    http://kertex.kergis.com/
Key fingerprint = 0FF7 E906 FBAF FE95 FD89  250D 52B1 AE95 6006 F40C


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99469): https://edk2.groups.io/g/devel/message/99469
Mute This Topic: https://groups.io/mt/96697952/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-