[edk2-devel] [PATCH 1/1] ArmPkg/SemihostFs: replace SetMem with ZeroMem
Rebecca Cran
rebecca at bsdio.com
Wed Feb 15 17:29:11 UTC 2023
Reviewed-by: Rebecca Cran <rebecca at bsdio.com>
On 2/15/23 07:37, Gerd Hoffmann wrote:
> SetMem arguments 2+3 are in the wrong order, resulting in
> the call having no effect because Length is zero.
>
> Fix this by using ZeroMem instead.
>
> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4205
> Reported-by: Jeremy Boone <jeremy.boone at nccgroup.com>
> Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
> ---
> ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c
> index 39a30533ee57..9cc9ed7d3637 100644
> --- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c
> +++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c
> @@ -574,7 +574,7 @@ ExtendFile (
> }
>
> Remaining = Size;
> - SetMem (WriteBuffer, 0, sizeof (WriteBuffer));
> + ZeroMem (WriteBuffer, sizeof (WriteBuffer));
> while (Remaining > 0) {
> WriteNb = MIN (Remaining, sizeof (WriteBuffer));
> WriteSize = WriteNb;
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100245): https://edk2.groups.io/g/devel/message/100245
Mute This Topic: https://groups.io/mt/96983558/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list