[edk2-devel] [edk2-platforms][PATCH 4/7] ManageabilityPkg: Initial package
Isaac Oram
isaac.w.oram at intel.com
Thu Feb 16 01:49:42 UTC 2023
I think that the ManageabilityPkg shouldn't have a file like CommonLibs.dsc.inc that defines commonly used content. It is the wrong scope. I would prefer to use the MinPlatformPkg content on the theory that it will move MinPlatformPkg to a more general location once it is in wider use.
Put another way, either we want many packages to include it, which is weird since the content isn't scoped to this package, or it is just for this package and others shouldn't include it, in which case, separating it from ManageabilityPkg.dsc via an include doesn't add anything.
If you don't want to use MinPlatformPkg then I would suggest following the original buildable package convention and put this content in the ManageabilityPkg/ManageabilityPkg.dsc.
"Manageabilty" is misspelled in a number of places in these files.
Regards,
Isaac
-----Original Message-----
From: abner.chang at amd.com <abner.chang at amd.com>
Sent: Tuesday, February 7, 2023 8:23 AM
To: devel at edk2.groups.io
Cc: Gao, Liming <gaoliming at byosoft.com.cn>; Oram, Isaac W <isaac.w.oram at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Abdul Lateef Attar <abdattar at amd.com>; Nickle Wang <nicklew at nvidia.com>; Igor Kulchytskyy <igork at ami.com>
Subject: [edk2-platforms][PATCH 4/7] ManageabilityPkg: Initial package
From: Abner Chang <abner.chang at amd.com>
Initial commit of ManageabilityPkg
Signed-off-by: Abner Chang <abner.chang at amd.com>
Cc: Liming Gao <gaoliming at byosoft.com.cn>
Cc: Isaac Oram <isaac.w.oram at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Abdul Lateef Attar <abdattar at amd.com>
Cc: Nickle Wang <nicklew at nvidia.com>
Cc: Igor Kulchytskyy <igork at ami.com>
---
.../ManageabilityPkg/ManageabilityPkg.dec | 18 +++++++++
.../Include/CommonLibs.dsc.inc | 40 +++++++++++++++++++
.../ManageabilityPkg/ManageabilityPkg.dsc | 23 +++++++++++
3 files changed, 81 insertions(+)
create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dec
create mode 100644 Features/ManageabilityPkg/Include/CommonLibs.dsc.inc
create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dsc
diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/ManageabilityPkg/ManageabilityPkg.dec
new file mode 100644
index 0000000000..8a0e28f50b
--- /dev/null
+++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
@@ -0,0 +1,18 @@
+## @file
+# Manageabilty Package
+# This is the package provides the edk2 drivers and libraries # those
+are related to the platform management.
+#
+# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
+reserved.<BR> # SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+[Defines]
+ DEC_SPECIFICATION = 0x0001001d
+ PACKAGE_NAME = ManageabilityPkg
+ PACKAGE_GUID = 36310119-4FB2-4BA3-959D-74C16B849F9E
+ PACKAGE_VERSION = 1.0
+
+[Includes]
+ Include
diff --git a/Features/ManageabilityPkg/Include/CommonLibs.dsc.inc b/Features/ManageabilityPkg/Include/CommonLibs.dsc.inc
new file mode 100644
index 0000000000..2dc2d07f17
--- /dev/null
+++ b/Features/ManageabilityPkg/Include/CommonLibs.dsc.inc
@@ -0,0 +1,40 @@
+## @file
+# Common libraries for Manageabilty Package # # Copyright (C) 2023
+Advanced Micro Devices, Inc. All rights reserved.<BR> #
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+[LibraryClasses]
+
+UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntr
+yPoint.inf
+
+UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBo
+otServicesTableLib.inf
+ UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
+ BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
+ BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
+ PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
+ DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
+ PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
+
+DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Base
+DebugPrintErrorLevelLib.inf
+ DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
+
+MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAl
+locationLib.inf
+
+[LibraryClasses.common.PEIM]
+ PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
+
+PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt
+/PeiServicesTablePointerLibIdt.inf
+ PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
+
+MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllo
+cationLib.inf
+ HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
+
+[LibraryClasses.common.DXE_SMM_DRIVER]
+
+SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTable
+Lib.inf
+
+MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllo
+cationLib.inf
+
+[LibraryClasses.ARM, LibraryClasses.AARCH64]
+ #
+ # This library provides the instrinsic functions generated by a given compiler.
+ #
+ NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
+ NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
+ ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
+
diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc b/Features/ManageabilityPkg/ManageabilityPkg.dsc
new file mode 100644
index 0000000000..9ae398277f
--- /dev/null
+++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc
@@ -0,0 +1,23 @@
+## @file
+# Manageabilty Package
+# This is the package provides edk2 drivers and libraries # those are
+related to the platform management.
+#
+# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
+reserved.<BR> # SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+[Defines]
+ PLATFORM_NAME = ManageabilityPkg
+ PLATFORM_GUID = 7A98123A-B194-40B6-A863-A52192F6D65D
+ PLATFORM_VERSION = 1.0
+ DSC_SPECIFICATION = 0x0001001e
+ OUTPUT_DIRECTORY = Build/ManageabilityPkg
+ SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64
+ BUILD_TARGETS = DEBUG|RELEASE|NOOPT
+ SKUID_IDENTIFIER = DEFAULT
+
+!include MdePkg/MdeLibs.dsc.inc
+!include ManageabilityPkg/Include/CommonLibs.dsc.inc
+
--
2.37.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100257): https://edk2.groups.io/g/devel/message/100257
Mute This Topic: https://groups.io/mt/96810551/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list