[edk2-devel] [edk2-platforms][PATCH v4 1/1] Ext4Pkg: Fixes double-free in Ext4ReadSymlink

[Marvin Häuser]

Reviewed-by: Marvin Häuser <mhaeuser at posteo.de>

> On 17. Feb 2023, at 09:56, Savva Mitrofanov <savvamtr at gmail.com> wrote:
> 
> The SymlinkTmp was deallocated unconditionally, so we shouldn't free it
> again on EFI_ERROR
> 
> Cc: Marvin Häuser <mhaeuser at posteo.de>
> Cc: Pedro Falcato <pedro.falcato at gmail.com>
> Cc: Vitaly Cheptsov <vit9696 at protonmail.com>
> Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support")
> Signed-off-by: Savva Mitrofanov <savvamtr at gmail.com>
> ---
> Features/Ext4Pkg/Ext4Dxe/Symlink.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/Features/Ext4Pkg/Ext4Dxe/Symlink.c b/Features/Ext4Pkg/Ext4Dxe/Symlink.c
> index 1189a99ded2b..d80cb9fff92e 100644
> --- a/Features/Ext4Pkg/Ext4Dxe/Symlink.c
> +++ b/Features/Ext4Pkg/Ext4Dxe/Symlink.c
> @@ -243,7 +243,6 @@ Ext4ReadSymlink (
>       Status
>       ));
>     FreePool (Symlink16Tmp);
> -    FreePool (SymlinkTmp);
>     return Status;
>   }
> 
> -- 
> 2.39.1
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100310): https://edk2.groups.io/g/devel/message/100310
Mute This Topic: https://groups.io/mt/97024664/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-