[edk2-devel] [edk2 1/1] BaseLib: don't log in InternalSwitchStack
Sunil V L
sunilvl at ventanamicro.com
Mon Feb 20 12:16:32 UTC 2023
Thanks for these fixes!, Andrei.
Could you please use below format for the subject?
PackageName: ModuleName: summary of changes
Also, could you create single patch series with these patches?
Otherwise,
Reviewed-by: Sunil V L <sunilvl at ventanamicro.com>
On Fri, Feb 17, 2023 at 10:29:21PM -0600, Andrei Warkentin wrote:
> InternalSwitchStack may be called with a TPL high
> enough for a DebugLib implementation to assert.
>
> Other arch implementations don't log either.
>
> Cc: Sunil V L <sunilvl at ventanamicro.com>
> Cc: Daniel Schaefer <git at danielschaefer.me>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Cc: Liming Gao <gaoliming at byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu at intel.com>
> Signed-off-by: Andrei Warkentin <andrei.warkentin at intel.com>
> ---
> MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c b/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c
> index cf646e498aba..b78424c16383 100644
> --- a/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c
> +++ b/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c
> @@ -44,14 +44,6 @@ InternalSwitchStack (
> {
> BASE_LIBRARY_JUMP_BUFFER JumpBuffer;
>
> - DEBUG ((
> - DEBUG_INFO,
> - "RISC-V InternalSwitchStack Entry:%x Context1:%x Context2:%x NewStack%x\n", \
> - EntryPoint,
> - Context1,
> - Context2,
> - NewStack
> - ));
> JumpBuffer.RA = (UINTN)EntryPoint;
> JumpBuffer.SP = (UINTN)NewStack - sizeof (VOID *);
> JumpBuffer.S0 = (UINT64)(UINTN)Context1;
> --
> 2.25.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100365): https://edk2.groups.io/g/devel/message/100365
Mute This Topic: https://groups.io/mt/97044162/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list