[edk2-devel] [Patch V2 2/5] UefiCpuPkg: Contiguous memory allocation and code clean-up.

Gerd Hoffmann kraxel at redhat.com
Tue Feb 21 09:26:15 UTC 2023


  Hi,

> +  Address    = BASE_4GB - 1;

Why do you set Address here ...

> +  Status = gBS->AllocatePages (
> +                  AllocateMaxAddress,
> +                  EfiReservedMemoryType,
> +                  StackPages+FuncPages,
> +                  &Address
> +                  );

... when it is overridden here anyway?

Otherwise the patch looks good to me.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100409): https://edk2.groups.io/g/devel/message/100409
Mute This Topic: https://groups.io/mt/97081030/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list