[edk2-devel] [PATCH 1/1] MdeModulePkg: Improve formatting of warning DEBUG in UsbSelectConfig

[Rebecca Cran]

That's the only USB debug message I noticed that seemed unclear.

Looking through the code I see a few others that could also be improved:


MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c
764:      "UsbGetOneConfig: failed to get descript length(%d) %r\n",
790:    DEBUG ((DEBUG_ERROR, "UsbGetOneConfig: failed to get full 
descript %r\n", Status));
894:    DEBUG ((DEBUG_INFO, "UsbBuildDescTable: get language ID table 
%r\n", Status));


-- 

Rebecca Cran


On 2/22/23 12:19 AM, Wu, Hao A wrote:
> Sorry, may I know why only this specific debug message requests format improving while others do not?
>
> Best Regards,
> Hao Wu
>
>> -----Original Message-----
>> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Rebecca
>> Cran
>> Sent: Tuesday, February 21, 2023 8:52 AM
>> To: devel at edk2.groups.io; Wang, Jian J <jian.j.wang at intel.com>; Gao, Liming
>> <gaoliming at byosoft.com.cn>; Wu, Hao A <hao.a.wu at intel.com>; Ni, Ray
>> <ray.ni at intel.com>
>> Cc: Rebecca Cran <rebecca at quicinc.com>
>> Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg: Improve formatting of
>> warning DEBUG in UsbSelectConfig
>>
>> Improve the formatting of a warning in UsbSelectConfig by adding parentheses
>> around the EFI_STATUS value.
>>
>> Signed-off-by: Rebecca Cran <rebecca at quicinc.com>
>> ---
>>   MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c
>> b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c
>> index aed34596f469..29a6419c3c86 100644
>> --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c
>> +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c
>> @@ -440,7 +440,7 @@ UsbSelectConfig (
>>       if (EFI_ERROR (Status)) {
>>         DEBUG ((
>>           DEBUG_WARN,
>> -        "UsbSelectConfig: failed to connect driver %r, ignored\n",
>> +        "UsbSelectConfig: failed to connect driver (%r), ignored\n",
>>           Status
>>           ));
>>       }
>> --
>> 2.30.2
>>
>>
>>
>>
>>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100440): https://edk2.groups.io/g/devel/message/100440
Mute This Topic: https://groups.io/mt/97099772/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-