[edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

[Yuanhao Xie]

-The above commit message is not quite clear.
-How about "Fix 32bit version AsmRelocateApLoopStart to retrieve the parameters from correct stack offset"?
-I also recommend that you split to 2 patches because the code change here fixes two bugs.

	Ok, I will split it as 2 patches with updated commit messages.

- Have you confirmed that the 32bit Linux boot hangs without the changes and succeeds with the changes?

	Yes, I confirmed.
	It hangs at: "CpuDxe: Level 5 paging = 0" without code changes. With the code changes, the "debug.log" continues to read "MpInitChangeApLoopCallback() done!". Linux debug messages are also displayed on the terminal.

Thanks,
Yuanhao
-----Original Message-----
From: Ni, Ray <ray.ni at intel.com> 
Sent: Thursday, January 5, 2023 2:29 PM
To: devel at edk2.groups.io; Xie, Yuanhao <yuanhao.xie at intel.com>
Cc: Laszlo Ersek <lersek at redhat.com>; Gerd Hoffmann <kraxel at redhat.com>; Ard Biesheuvel <ardb at kernel.org>
Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

> Fixed AsmRelocateApLoopStart stack offset in Ia32.

The above commit message is not quite clear.
How about "Fix 32bit version AsmRelocateApLoopStart to retrieve the parameters from correct stack offset"?

I also recommend that you split to 2 patches because the code change here fixes two bugs.

Have you confirmed that the 32bit Linux boot hangs without the changes and succeeds with the changes?

Thanks,
Ray


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97974): https://edk2.groups.io/g/devel/message/97974
Mute This Topic: https://groups.io/mt/96067843/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-