[edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish

Isaac Oram isaac.w.oram at intel.com
Thu Jan 5 17:41:36 UTC 2023


Series pushed as: 28f3ce4a6a251de327b8d19c3316a654887f4f13.. f5da8af6befbfc655fd3e4cb899eda158dd9ede5

My apologies, I was sloppy and didn't ensure the edk2 changes were pushed first, so IpmiFeaturePkg build is currently broken pending https://edk2.groups.io/g/devel/message/97789being being pushed.

Regards,
Isaac


-----Original Message-----
From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Isaac Oram
Sent: Thursday, January 5, 2023 9:05 AM
To: abner.chang at amd.com; devel at edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Kinney, Michael D <michael.d.kinney at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu at intel.com>; Nickle Wang <nicklew at nvidia.com>; Igor Kulchytskyy <igork at ami.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish

Series Reviewed-by: Isaac Oram <isaac.w.oram at intel.com>

-----Original Message-----
From: abner.chang at amd.com <abner.chang at amd.com> 
Sent: Thursday, January 5, 2023 8:01 AM
To: devel at edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Kinney, Michael D <michael.d.kinney at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu at intel.com>; Nickle Wang <nicklew at nvidia.com>; Igor Kulchytskyy <igork at ami.com>
Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish

From: Abner Chang <abner.chang at amd.com>

In V2: Addressed the comments from Isaac.

BZ# 4214
This patch adds IPMI functions for building up SMBIOS 42 record for the USB NIC host interface exposed by BMC.
The corresponding updates on edk2 is in the separate pacth.

This is the part I of upstream, the follow up patche sets are:
- RedfishPlatformCredentialLib contributed by NVidia.
- Relocate IpmiCommandLib.h from edk2-platforms
  to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
  and located under MdePkg. With above, RedfishPkg doesn't have the
  dependence with edk2-platforms. The implementation of IpmiCommandLib
  stays in edk2-platforms without relocation, which can be pulled in
  to platform DSC as needed.
- PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
  temporarily because some requirements are necessray to be spec out
  in the Redfish section in UEFI spec.

Signed-off-by: Abner Chang <abner.chang at amd.com>
Cc: Isaac Oram <isaac.w.oram at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Michael D Kinney <michael.d.kinney at intel.com>
Cc: Liming Gao <gaoliming at byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu at intel.com>
Cc: Nickle Wang <nicklew at nvidia.com>
Cc: Igor Kulchytskyy <igork at ami.com>

Abner Chang (3):
  Features/IpmiFeaturePkg: Add IPMI functions
  IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions
  IpmiFeaturePkg: Add reference of IpmiBaseLib

 .../IpmiFeaturePkg/IpmiFeaturePkg.dec         |  5 ++
 .../Include/Library/IpmiCommandLib.h          | 62 +++++++++++++
 .../IpmiCommandLib/IpmiCommandLibNetFnApp.c   | 88 +++++++++++++++++++
 .../IpmiCommandLibNetFnTransport.c            | 43 +++++++++
 4 files changed, 198 insertions(+)

--
2.37.1.windows.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98030): https://edk2.groups.io/g/devel/message/98030
Mute This Topic: https://groups.io/mt/96074589/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list