[edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs

[Michael D Kinney]

Hi,

Can you add a before and after picture to the PR for the glyphs that have been updated.

Thanks,

Mike

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Jan Engelhardt
> Sent: Saturday, January 7, 2023 7:16 AM
> To: devel at edk2.groups.io
> Subject: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs
> 
> Signed-off-by: Jan Engelhardt <jengelh at inai.de>
> ---
> This was previously posted to https://github.com/tianocore/edk2/pull/3330
> where you can see a visual representation of what is being corrected.
> 
>  .../Universal/Console/GraphicsConsoleDxe/LaffStd.c     | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
> b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
> index 1f7fe4cda8..99d909592c 100644
> --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
> +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/LaffStd.c
> @@ -213,13 +213,13 @@ EFI_NARROW_GLYPH  gUsStdNarrowGlyphData[] = {
>    },
> 
>    { 0x00a3,                                     0x00, { 0x00, 0x00, 0x00, 0x38, 0x6C, 0x64, 0x60, 0x60, 0xF0, 0x60, 0x60, 0x60,
> 0x60, 0xE6, 0xFC, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00a4,                                     0x00, { 0x00, 0x00, 0x18, 0x00, 0x00, 0x00, 0xC6, 0x7C, 0xC6, 0xC6, 0xC6, 0xC6,
> 0x7C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00a4,                                     0x00, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xC6, 0x7C, 0xC6, 0xC6, 0xC6, 0xC6,
> 0x7C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00a5,                                     0x00, { 0x00, 0x00, 0x00, 0x66, 0x66, 0x66, 0x3C, 0x18, 0x7E, 0x18, 0x7E, 0x18,
> 0x18, 0x18, 0x18, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00a6,                                     0x00, { 0x00, 0x00, 0x00, 0x18, 0x18, 0x18, 0x18, 0x18, 0x00, 0x00, 0x18, 0x18,
> 0x18, 0x18, 0x18, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00a7,                                     0x00, { 0x00, 0x00, 0x18, 0x7C, 0xC6, 0x60, 0x38, 0x6C, 0xC6, 0xC6, 0x6C, 0x38,
> 0x0C, 0xC6, 0x7C, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00a7,                                     0x00, { 0x00, 0x00, 0x00, 0x7C, 0xC6, 0x60, 0x38, 0x6C, 0xC6, 0xC6, 0x6C, 0x38,
> 0x0C, 0xC6, 0x7C, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00a8,                                     0x00, { 0x00, 0x00, 0x00, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> @@ -315,7 +315,7 @@ EFI_NARROW_GLYPH  gUsStdNarrowGlyphData[] = {
>    },
> 
>    { 0x00d6,                                     0x00, { 0xCC, 0xCC, 0x00, 0x00, 0x7C, 0xC6, 0xC6, 0xC6, 0xC6, 0xC6, 0xC6, 0xC6,
> 0xC6, 0xC6, 0x7C, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00d7,                                     0x00, { 0x10, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0xC6, 0x6C, 0x38, 0x38, 0x6C,
> 0x6C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00d7,                                     0x00, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xC6, 0x6C, 0x38, 0x38, 0x6C,
> 0x6C, 0xC6, 0x00, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00d8,                                     0x00, { 0x00, 0x00, 0x00, 0x7C, 0xCE, 0xCE, 0xDE, 0xD6, 0xD6, 0xD6, 0xD6, 0xF6,
> 0xE6, 0xE6, 0x7C, 0x40, 0x00, 0x00, 0x00 }
> 
>    },
> 
> @@ -329,11 +329,11 @@ EFI_NARROW_GLYPH  gUsStdNarrowGlyphData[] = {
>    },
> 
>    { 0x00dd,                                     0x00, { 0x18, 0x30, 0x00, 0x00, 0x66, 0x66, 0x66, 0x66, 0x66, 0x3C, 0x18, 0x18,
> 0x18, 0x18, 0x3C, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00de,                                     0x00, { 0x00, 0x00, 0x10, 0x00, 0xF0, 0x60, 0x60, 0x7C, 0x66, 0x66, 0x66, 0x66,
> 0x7C, 0x60, 0xF0, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00de,                                     0x00, { 0x00, 0x00, 0x00, 0x00, 0xF0, 0x60, 0x60, 0x7C, 0x66, 0x66, 0x66, 0x66,
> 0x7C, 0x60, 0xF0, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00df,                                     0x00, { 0x00, 0x00, 0x00, 0x78, 0xCC, 0xCC, 0xCC, 0xCC, 0xD8, 0xCC, 0xC6, 0xC6,
> 0xC6, 0xC6, 0xCC, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> -  { 0x00e0,                                     0x00, { 0x00, 0x30, 0x30, 0x60, 0x30, 0x18, 0x00, 0x78, 0x0C, 0x0C, 0x7C, 0xCC,
> 0xCC, 0xCC, 0x76, 0x00, 0x00, 0x00, 0x00 }
> 
> +  { 0x00e0,                                     0x00, { 0x00, 0x00, 0x00, 0x60, 0x30, 0x18, 0x00, 0x78, 0x0C, 0x0C, 0x7C, 0xCC,
> 0xCC, 0xCC, 0x76, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
>    { 0x00e1,                                     0x00, { 0x00, 0x00, 0x00, 0x18, 0x30, 0x60, 0x00, 0x78, 0x0C, 0x0C, 0x7C, 0xCC,
> 0xCC, 0xCC, 0x76, 0x00, 0x00, 0x00, 0x00 }
> 
>    },
> 
> --
> 2.39.0
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#98148): https://edk2.groups.io/g/devel/message/98148
> Mute This Topic: https://groups.io/mt/96117470/1643496
> Group Owner: devel+owner at edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney at intel.com]
> -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98149): https://edk2.groups.io/g/devel/message/98149
Mute This Topic: https://groups.io/mt/96117470/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-