[edk2-devel] [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Add back log and fix code cohesion

[Min Xu]

Laszlo & Gerd
Yes, I will provide a new patch-set with 6 patches. Thanks for your comments.

Min

> -----Original Message-----
> From: Laszlo Ersek <lersek at redhat.com>
> Sent: Thursday, January 5, 2023 11:11 PM
> To: Gerd Hoffmann <kraxel at redhat.com>; devel at edk2.groups.io; Xu, Min
> M <min.m.xu at intel.com>
> Cc: Aktas, Erdem <erdemaktas at google.com>; James Bottomley
> <jejb at linux.ibm.com>; Yao, Jiewen <jiewen.yao at intel.com>; Tom Lendacky
> <thomas.lendacky at amd.com>; Boeuf, Sebastien
> <sebastien.boeuf at intel.com>
> Subject: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Add
> back log and fix code cohesion
> 
> On 1/5/23 14:15, Gerd Hoffmann wrote:
> > On Wed, Jan 04, 2023 at 10:13:09PM +0800, Min Xu wrote:
> >> From: Min M Xu <min.m.xu at intel.com>
> >>
> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237
> >>
> >> Commit 9fdc70af6ba8 breaks log analysis and code cohesion in
> >> AcpiPlatformDxe. See the detailed information in BZ#4237.
> >>
> >> There are below changes in this patch:
> >> 1) Add back debug log
> >> 2) Add error checking and handling if InstallProtocolInterface failed.
> >> 3) Delete the QemuAcpiTableNotify.h because it is superfluous.
> >> 4) Delete the global variable "mQemuAcpiHandle" instead of a local
> >>    variable.
> >> 5) Install the QEMU_ACPI_TABLE_NOTIFY_PROTOCOL with a NULL
> associated
> >>    interface.
> >
> > Five changes in a single patch.  Can this be splitted up please?
> 
> Right, I've requested 6 patches :)
> Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98157): https://edk2.groups.io/g/devel/message/98157
Mute This Topic: https://groups.io/mt/96050679/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-