[edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
Ning Feng
ning.feng at intel.com
Mon Jan 9 05:03:54 UTC 2023
Hi, @Guo, Gua<mailto:gua.guo at intel.com>,
Thanks for the review.
I have already fix the commit message, and create the PR.
UefiPayloadPkg: Fix debug print error level hob not save correct by NingFengGit · Pull Request #3868 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3868>
Thanks,
Ning
From: Guo, Gua <gua.guo at intel.com>
Sent: Monday, January 9, 2023 9:58 AM
To: devel at edk2.groups.io; Feng, Ning <ning.feng at intel.com>
Cc: Lu, James <james.lu at intel.com>; Guo, Dong <dong.guo at intel.com>; Ni, Ray <ray.ni at intel.com>; Rhodes, Sean <sean at starlabs.systems>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
@Feng, Ning<mailto:ning.feng at intel.com>
Could you send Edk2 PR ? we can check in it.
https://github.com/tianocore/edk2/pulls
And please also change commit message like below
“””
UefiPayloadPkg: Fix debug print error level hob not save correct
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4264
Fix debug print error level hob not save correct DebugPrintErrorlevel
Should cover the case:
Header.Length == UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()
Cc: Ray Ni <ray.ni at intel.com<mailto:ray.ni at intel.com>>
Cc: Sean Rhodes <sean at starlabs.systems<mailto:sean at starlabs.systems>>
Cc: James Lu <james.lu at intel.com<mailto:james.lu at intel.com>>
Cc: Gua Guo <gua.guo at intel.com<mailto:gua.guo at intel.com>>
Signed-off-by: Ning Feng <ning.feng at intel.com<mailto:ning.feng at intel.com>>
Reviewed-by: Gua Guo <gua.guo at intel.com<mailto:gua.guo at intel.com>>
“””
Reviewed-by: Gua Guo <gua.guo at intel.com<mailto:gua.guo at intel.com>>
From: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>> On Behalf Of Ning Feng
Sent: Monday, January 9, 2023 9:44 AM
To: Feng, Ning <ning.feng at intel.com<mailto:ning.feng at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
fix debug print error level hob not save correct debugprinterrorlevel
should cover the case:
Header.Lenth ==UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()
Change-Id: Ibebe29fe8057e24448b31a8caa7ab6eb8054c39b
BugZilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4264
Signed-off-by: Ning Feng <ning.feng at intel.com<mailto:ning.feng at intel.com>>
---
.../DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c
index 4f6b4ef1fb..10bdbe2bbc 100644
--- a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c
+++ b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorL
+++ evelLibHob.c
@@ -46,7 +46,7 @@ GetDebugPrintErrorLevel (
{ if (GenericHeader->Revision == UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL_REVISION) { DebugPrintErrorLevel = (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL *)GET_GUID_HOB_DATA (GuidHob);- if (DebugPrintErrorLevel->Header.Length > UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {+ if (DebugPrintErrorLevel->Header.Length >= UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) { gDebugPrintErrorLevel = DebugPrintErrorLevel->ErrorLevel; } }--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98169): https://edk2.groups.io/g/devel/message/98169
Mute This Topic: https://groups.io/mt/96090853/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20230109/09024fbf/attachment-0001.htm>
More information about the edk2-devel-archive
mailing list