[edk2-devel] [PATCH v2 0/6] Adds AmdSmmCpuFeaturesLib
Laszlo Ersek
lersek at redhat.com
Thu Jan 12 13:04:45 UTC 2023
On 1/11/23 07:15, Abdul Lateef Attar via groups.io wrote:
> V2 series addresses review comments from V1.
> Adds SmmSmramSaveStateLib library
> Removes global references across modules.
> drops S3 support patch.
>
> PR: https://github.com/tianocore/edk2/pull/3882
>
> Cc: Paul Grimes <paul.grimes at amd.com>
> Cc: Garrett Kirkendall <garrett.kirkendall at amd.com>
> Cc: Abner Chang <abner.chang at amd.com>
> Cc: Eric Dong <eric.dong at intel.com>
> Cc: Ray Ni <ray.ni at intel.com>
> Cc: Rahul Kumar <rahul1.kumar at intel.com>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Cc: Liming Gao <gaoliming at byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu at intel.com>
>
> Abdul Lateef Attar (6):
> UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code
> MdePkg: Adds AMD SMRAM save state map
> UefiCpuPkg: Adds SmmSmramSaveStateLib library class
> UefiCpuPkg: Implements SmmSmramSaveStateLib library class
> UefiCpuPkg: Initial implementation of AMD's SmmCpuFeaturesLib
> UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family
>
> UefiCpuPkg/UefiCpuPkg.dec | 4 +
> UefiCpuPkg/UefiCpuPkg.dsc | 11 +
> .../AmdSmmCpuFeaturesLib.inf | 39 ++
> .../AmdSmmSmramSaveStateLib.inf | 28 ++
> .../Include/Register/Amd/SmramSaveStateMap.h | 194 ++++++++
> .../Include/Library/SmmSmramSaveStateLib.h | 69 +++
> .../SmmSmramSaveStateLib/SmramSaveState.h | 102 ++++
> .../SmmCpuFeaturesLib/Amd/SmmCpuFeaturesLib.c | 445 ++++++++++++++++++
> .../IntelSmmCpuFeaturesLib.c | 128 +++++
> .../SmmCpuFeaturesLibCommon.c | 128 -----
> .../SmmSmramSaveStateLib/Amd/SmramSaveState.c | 318 +++++++++++++
> .../SmramSaveStateCommon.c | 124 +++++
> MdePkg/MdePkg.ci.yaml | 3 +-
> 13 files changed, 1464 insertions(+), 129 deletions(-)
> create mode 100644 UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.inf
> create mode 100644 UefiCpuPkg/Library/SmmSmramSaveStateLib/AmdSmmSmramSaveStateLib.inf
> create mode 100644 MdePkg/Include/Register/Amd/SmramSaveStateMap.h
> create mode 100644 UefiCpuPkg/Include/Library/SmmSmramSaveStateLib.h
> create mode 100644 UefiCpuPkg/Library/SmmSmramSaveStateLib/SmramSaveState.h
> create mode 100644 UefiCpuPkg/Library/SmmCpuFeaturesLib/Amd/SmmCpuFeaturesLib.c
> create mode 100644 UefiCpuPkg/Library/SmmSmramSaveStateLib/Amd/SmramSaveState.c
> create mode 100644 UefiCpuPkg/Library/SmmSmramSaveStateLib/SmramSaveStateCommon.c
>
- Is there a feature BZ for this?
There should be. Explaining the goal of the patch set belongs there.
Plus, if there is a feature BZ like that, it can be included in the
Proposed Features list at
<https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning>,
and then associated with the next release notes at
<https://github.com/tianocore/edk2/releases>.
- OVMF's SmmCpuFeaturesLib (OvmfPkg/Library/SmmCpuFeaturesLib) matches
QEMU, and QEMU uses the AMD flavor of the save state map.
I don't think OVMF's library instance can be used for physical AMD
processors whole-sale, so the library instances should remain separate.
However, the register maps could be shared by some means, perhaps.
- Please copy Gerd on UefiCpuPkg patches, per commit 0aca5901e344
("Maintainers.txt: designate Gerd Hoffmann as UefiCpuPkg reviewer",
2023-01-06).
Thanks for considering.
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98364): https://edk2.groups.io/g/devel/message/98364
Mute This Topic: https://groups.io/mt/96195131/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list