[edk2-devel] [PATCH v2 3/4] UefiCpuPkg/SmmCpuFeaturesLib: Skip to configure SMBASE

[Chang, Abner via groups.io]

[AMD Official Use Only - General]



> -----Original Message-----
> From: Ni, Ray <ray.ni at intel.com>
> Sent: Monday, January 16, 2023 1:38 PM
> To: devel at edk2.groups.io; Chang, Abner <Abner.Chang at amd.com>; Wu,
> Jiaxin <jiaxin.wu at intel.com>
> Cc: Dong, Eric <eric.dong at intel.com>; Zeng, Star <star.zeng at intel.com>;
> Laszlo Ersek <lersek at redhat.com>; Gerd Hoffmann <kraxel at redhat.com>;
> Kumar, Rahul R <rahul.r.kumar at intel.com>
> Subject: RE: [edk2-devel] [PATCH v2 3/4] UefiCpuPkg/SmmCpuFeaturesLib:
> Skip to configure SMBASE
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> > > +  //
> > > +  // If gSmmBaseHobGuid found, means SmBase info has been relocated
> > > and
> > > + recorded  // in the SmBase array.
> > > +  //
> > > +  mSmmCpuFeaturesSmmRelocated = (BOOLEAN)(GetFirstGuidHob
> > > + (&gSmmBaseHobGuid) != NULL);
> > We can have this code and mSmmCpuFeaturesSmmRelocated in the
> > SmmCpuFeaturesLibConstructor so this mechanism can be leverage by
> other vendors.
> 
> Abner,
> I guess you found this logic is useful in AMD flow.
> Let's keep the current change as is and you could refactor the code later to
> present a full picture how AMD flow is like.
This is also fine to me.
Thanks
Abner
> 
> Thanks,
> Ray


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98549): https://edk2.groups.io/g/devel/message/98549
Mute This Topic: https://groups.io/mt/96247965/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-