[edk2-devel] [PATCH v1 0/4] Support SMM Relocated SmBase handling

[Gerd Hoffmann]

On Fri, Jan 13, 2023 at 12:47:54PM +0000, Wu, Jiaxin wrote:
> > 
> > There are no PEI module changes in this patch series.
> > 
> > So where does the HOB come from?
> 
> Who use, who produce. Here, just provide the interface capability.   

Well, yes.  This series adds the interface (i.e. the HOB guid
and struct).  It also updates some modules which consume that
new interface.

It does *not* add a producer of that new interface.

> > And what are the reasons for setting SMBASE in a PEI module instead
> > of PiSmmCpuDxeSmm?
> 
> Do the smbase relocated ahead of SMM cpu driver can bring the benefit
> as I explain in the patch 2:

> PiSmmCpuDxeSmm will retrieve the SMBASE addresses from SMM Base Hob
> and installs the SMI handler at [SMBASE+8000h] for each processor
> instead of relocating SMM Base addresses from SMRAM again.

That doesn't answer my question.

Sure, if you do the SMM Base relocation somewhere else PiSmmCpuDxeSmm
shouldn't do it again.

It is not clear why you do the SMM Base relocation somewhere else.
The code for that is also not present in this patch series.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98553): https://edk2.groups.io/g/devel/message/98553
Mute This Topic: https://groups.io/mt/96241699/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-