[edk2-devel] [PATCH v2] Update CPUID Leaf 06H to follow latest SDM.

Ni, Ray ray.ni at intel.com
Mon Jan 16 09:19:22 UTC 2023


Donald,
Old code might reference existing Reserved field in the structure definition.
So, to avoid old code assigning value to different bits if using same field name but for different bits position,
edk2 recommends to change the field name from ReservedX to ReservedY when the bits covered by ReservedX
are changed. Y is the next unused index.

So comments as below:

> 
> -    UINT32    Reserved5                              : 11;
> 
> +    UINT32    Reserved4                              : 2;
We should rename Reserved5 to Reserved6.


> 
> +    UINT32    IA32_THERM_INTERRUPT                   : 1;
> 
> +    UINT32    Reserved5                              : 7;
Reserved7.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98561): https://edk2.groups.io/g/devel/message/98561
Mute This Topic: https://groups.io/mt/96250318/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list