[edk2-devel] [PATCH v10 2/4] MdePkg: Introduce the SevMemoryAcceptance protocol

Ard Biesheuvel ardb at kernel.org
Thu Jan 26 17:19:52 UTC 2023


On Thu, 26 Jan 2023 at 18:04, Dionna Amalie Glaze
<dionnaglaze at google.com> wrote:
>
> > As Gerd and I discussed before, this protocol should be in OvmfPkg.
> > Please move to https://github.com/tianocore/edk2/tree/master/OvmfPkg/Include/Protocol
> >
>
> Ah, I misinterpreted your response to Gerd's message. v11 will have it
> moved. The CI seems to think I've redefined the protocol struct type
> or failed to use the typedef for declarations, but I don't see how
> that would be. Is this a false positive that I can ignore for the next
> iteration? https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=78271&view=results
>

That looks very odd to me, and I don't see anything wrong with the .h file.

However, since we are moving this to OvmfPkg and you are spinning a
v11, can we drop the bizarre prefix please?

Also, the 'extern EFI_GUID xxx' should be unnecessary these days -
these are generated by the build tools based on the [Protocols]
section in the INF.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99087): https://edk2.groups.io/g/devel/message/99087
Mute This Topic: https://groups.io/mt/96534753/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list