[edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

[Xue, Gavin]

Hi Sunil/Pedro,

1. As you know, ProcessorBind.h file of CPU Architecture file declares sets of base types for edk2 code compiling.
So data type in edk2 code doesn't rely on specific compiler (msvc, gcc etc.), which is a good design.

But in practice, for the purpose of reuse, some code can be built with edk2, and also can be built to a standalone application (e.g. Win App).
Just like below code piece:
===========
#ifndef __WRAPPER_BASE_TYPES_H__
#define __WRAPPER_BASE_TYPES_H__

//
// To avoid definition conflict during EDK2 build, it must include
// ProcessorBind.h before xxx.h
//
#ifndef __PROCESSOR_BIND_H__

#include <stdint.h>
typedef uint8_t  UINT8;
==========

In this case, if this is a edk2 build, the code will refer to data types from ProcessorBind.h, otherwise, it will refer to stdint.h from compiler.

2. Regarding the guard name, it's same __PROCESSOR_BIND_H__ macro in AArch64/Arm/Ebc/Ia32/X64, but it is PROCESSOR_BIND_H_
in RiscV64 and LoongArh64. For above code, if we build BIOS for RISCV64, it will try to include stdint.h due to different guard name.

I am not sure if we can use same guard name to keep code alignment, or give some comments. Thanks.

Best regards,
Gavin

-----Original Message-----
From: Pedro Falcato <pedro.falcato at gmail.com> 
Sent: Friday, June 16, 2023 10:12 PM
To: devel at edk2.groups.io; sunilvl at ventanamicro.com
Cc: Xue, Gavin <gavin.xue at intel.com>; Warkentin, Andrei <andrei.warkentin at intel.com>; Wang, Yimin <yimin.wang at intel.com>; Sheng, Alan <alan.sheng at intel.com>
Subject: Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

On Fri, Jun 16, 2023 at 11:36 AM Sunil V L <sunilvl at ventanamicro.com> wrote:
>
> On Fri, Jun 16, 2023 at 03:22:57PM +0800, Gavin Xue wrote:
> > Different symbol (PROCESSOR_BIND_H__) define in RISCV64 
> > ProcessorBinding.h from other CPU Arch. An unexception compilation 
> > error generated if include __PROCESSOR_BIND_H__ symbol in header 
> > file for cross-platform compiling.

(replying through Sunil's reply as the original email doesn't seem to have been sent to the list)

What exactly is the problem here? The header has its include guard, you include it once, it defines PROCESSOR_BIND_H__, you include it twice, the #ifndef doesn't pass and nothing gets "included" again.
I really don't understand what your problem is, here. Particularly the __PROCESSOR_BIND_H__ inclusion bit, this all seems like a giant hack.

--
Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106189): https://edk2.groups.io/g/devel/message/106189
Mute This Topic: https://groups.io/mt/99567569/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-