[edk2-devel] [RFC PATCH] ArmPkg: Enable AuditMode for Uncrustify CI checks

[Gerd Hoffmann]

  Hi,

> > In AArch64Mmu.h, I agree that preserving the (mostly) global column as
> > opposed to block-specific columns would be easier to vertically scan. Is
> > that the main issue in the file?
> 
> Yes.

It is possible to exclude specific files from checks, see CryptoPkg for
example which does this for some files generated by openssl configure.

> I'm sure this all seems quite reasonable if you already bought into
> using uncrustify. But for a drive-by contributor, or someone like me
> who has been contributing code for many years based on the agreed
> coding style guidelines, I struggle to understand why uncrustify is a
> reasonable solution to the problem of inconsistent coding style.

I find it quite nice.  Yes, you have to invest the time to set things up
once.  But then you can just delegate all code formating to uncrustify
instead of doing it manually.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106254): https://edk2.groups.io/g/devel/message/106254
Mute This Topic: https://groups.io/mt/99282612/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-