[edk2-devel] [PATCH v1 0/2] Support MM based variable services in PEI for ARM

[Sami Mujawar]

Hi Kun,

Apologies for the delay in reviewing.
I will take a look at this series shortly and get back.

Regards,

Sami Mujawar

On 22/06/2023, 06:07, "Kun Qin" <kuqin12 at gmail.com <mailto:kuqin12 at gmail.com>> wrote:


Hi Arm and MdeModule package maintainers,


This patch series has been sent out for almost 2 weeks without any reviews.


Could you please provide feedback on the change when you have a chance?
Any input is appreciated.


Regards,
Kun


On 6/8/2023 1:44 PM, Kun Qin via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 <https://bugzilla.tianocore.org/show_bug.cgi?id=4464>
>
> As of today, there has been a void in the variable service in PEI phase
> on ARM systems that support PEI phase and standalone MM hosted variable
> service.
>
> This change adds the support through:
> 1. Add MM communication services in PEI phase for ARM platforms. This
> module is based on SMC calls to standalone MM environments, similar to
> "ArmPkg/Drivers/MmCommunicationDxe".
>
> 2. A service module that installs `gEfiPeiReadOnlyVariable2PpiGuid` based
> on step 1. Note that this driver will not have special dependency on ARM
> specific code, thus will be ideally added to MdeModulePkg.
>
> Patch v1 branch: https://github.com/kuqin12/edk2/tree/arm_var_pei_v1 <https://github.com/kuqin12/edk2/tree/arm_var_pei_v1>
>
> Cc: Hao A Wu <hao.a.wu at intel.com <mailto:hao.a.wu at intel.com>>
> Cc: Liming Gao <gaoliming at byosoft.com.cn <mailto:gaoliming at byosoft.com.cn>>
> Cc: Jian J Wang <jian.j.wang at intel.com <mailto:jian.j.wang at intel.com>>
> Cc: Leif Lindholm <quic_llindhol at quicinc.com <mailto:quic_llindhol at quicinc.com>>
> Cc: Ard Biesheuvel <ardb+tianocore at kernel.org <mailto:ardb+tianocore at kernel.org>>
> Cc: Sami Mujawar <sami.mujawar at arm.com <mailto:sami.mujawar at arm.com>>
>
> Kun Qin (2):
> ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI
> MdeModulePkg: Variable: Introduce MM based variable read service in
> PEI
>
> ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c | 178 +++++++++
> MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.c | 381 ++++++++++++++++++++
> ArmPkg/ArmPkg.dsc | 2 +
> ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.h | 76 ++++
> ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.inf | 41 +++
> MdeModulePkg/MdeModulePkg.dsc | 1 +
> MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.h | 134 +++++++
> MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.inf | 43 +++
> 8 files changed, 856 insertions(+)
> create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c
> create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.c
> create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.h
> create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.inf
> create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.h
> create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.inf
>





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106278): https://edk2.groups.io/g/devel/message/106278
Mute This Topic: https://groups.io/mt/99415823/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-