[edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg

Guo, Gua gua.guo at intel.com
Tue Jun 27 01:24:37 UTC 2023 

@Gao, Liming<mailto:gaoliming at byosoft.com.cn>

In fact, I also want to move it edk2/MdeModulePkg/Include/UniversalPayload at master · tianocore/edk2 · GitHub<https://github.com/tianocore/edk2/tree/master/MdeModulePkg/Include/UniversalPayload> to MdePkg step by step, but it another, for the mail thread we can focus on TraceHub Hob move to MdePkg responsibility.

As you know, Intel silicon may also provide MMIO UART
https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h This HOB need to provide by silicon code in the future will be made sense.

We can review patch one by one and consider whether it’s make sense or not.

In past, we discuss it with Mike, TraceHub can support UPL enable case and UPL disable case.
So recommend us to put it into common area. It’s background.
Past PR: MdeModulePkg: Add Trace Hub Debug Library by hsuc1x · Pull Request #3613 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3613/files>

  *   MdeModulePkg/Include/UniversalPayload/TraceHubDebugInfo.h
[cid:image003.png at 01D9A8D9.28D18690]


Thanks,
Gua


From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Guo, Gua
Sent: Tuesday, June 27, 2023 9:17 AM
To: Gao, Liming <gaoliming at byosoft.com.cn>; devel at edk2.groups.io; Ni, Ray <ray.ni at intel.com>; Hsu, VictorX <victorx.hsu at intel.com>
Cc: 'Chan Laura' <laura.chan at intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan at intel.com>; K N, Karthik <karthik.k.n at intel.com>
Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg

In past, we discuss it with Mike, TraceHub can support UPL enable case and UPL disable case.
So recommend us to put it into common area. It’s background.

Thanks,
Gua

From: gaoliming <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>
Sent: Tuesday, June 27, 2023 9:12 AM
To: Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>; Ni, Ray <ray.ni at intel.com<mailto:ray.ni at intel.com>>; Hsu, VictorX <victorx.hsu at intel.com<mailto:victorx.hsu at intel.com>>
Cc: 'Chan Laura' <laura.chan at intel.com<mailto:laura.chan at intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan at intel.com<mailto:krishnadas.veliyathuparambil.prakashan at intel.com>>; K N, Karthik <karthik.k.n at intel.com<mailto:karthik.k.n at intel.com>>
Subject: 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg

Guo:
 Now, UniversalPayload definitions are in MdeModulePkg\Include\UniversalPayload directory. For example, PCI Root Bridges HOB is defined in MdeModulePkg\Include\UniversalPayload\PciRootBridges.h. So, I think this definition should be placed in the same place.

Thanks
Liming
发件人: Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>
发送时间: 2023年6月26日 11:42
收件人: devel at edk2.groups.io<mailto:devel at edk2.groups.io>; Gao, Liming <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>; Ni, Ray <ray.ni at intel.com<mailto:ray.ni at intel.com>>; Hsu, VictorX <victorx.hsu at intel.com<mailto:victorx.hsu at intel.com>>
抄送: 'Chan Laura' <laura.chan at intel.com<mailto:laura.chan at intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan at intel.com<mailto:krishnadas.veliyathuparambil.prakashan at intel.com>>; K N, Karthik <karthik.k.n at intel.com<mailto:karthik.k.n at intel.com>>
主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg

@Gao, Liming<mailto:gaoliming at byosoft.com.cn>

It’s defined on  https://universalscalablefirmware.github.io/documentation/2_universal_payload.html#trace-hub-hob-information
[cid:image001.png at 01D9A8D8.B7A8DE00]

Thanks,
Gua
From: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>> On Behalf Of gaoliming via groups.io
Sent: Sunday, June 25, 2023 9:22 AM
To: Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>; Ni, Ray <ray.ni at intel.com<mailto:ray.ni at intel.com>>; Hsu, VictorX <victorx.hsu at intel.com<mailto:victorx.hsu at intel.com>>
Cc: 'Chan Laura' <laura.chan at intel.com<mailto:laura.chan at intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan at intel.com<mailto:krishnadas.veliyathuparambil.prakashan at intel.com>>; K N, Karthik <karthik.k.n at intel.com<mailto:karthik.k.n at intel.com>>
Subject: 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg

Guo:
 MdePkg definitions are from the industry standard. Which document defines TraceHubDebugInfoHob?

Thanks
Liming
发件人: Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>
发送时间: 2023年6月21日 22:25
收件人: devel at edk2.groups.io<mailto:devel at edk2.groups.io>; Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>; Ni, Ray <ray.ni at intel.com<mailto:ray.ni at intel.com>>; Hsu, VictorX <victorx.hsu at intel.com<mailto:victorx.hsu at intel.com>>
抄送: Gao, Liming <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>; Chan Laura <laura.chan at intel.com<mailto:laura.chan at intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan at intel.com<mailto:krishnadas.veliyathuparambil.prakashan at intel.com>>; K N, Karthik <karthik.k.n at intel.com<mailto:karthik.k.n at intel.com>>
主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg

Hi Victor

Could you help to move below header file to MdePkg on Maintainer.txt ?

[cid:image002.png at 01D9A8D8.B7A8DE00]


Thanks,
Gua

From: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>> On Behalf Of Guo, Gua
Sent: Wednesday, June 21, 2023 9:27 PM
To: Ni, Ray <ray.ni at intel.com<mailto:ray.ni at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>; Hsu, VictorX <victorx.hsu at intel.com<mailto:victorx.hsu at intel.com>>
Cc: Gao, Liming <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>; Chan Laura <laura.chan at intel.com<mailto:laura.chan at intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan at intel.com<mailto:krishnadas.veliyathuparambil.prakashan at intel.com>>; K N, Karthik <karthik.k.n at intel.com<mailto:karthik.k.n at intel.com>>
Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg

SiliconPkg can build the hob so have the HOB interface is enough. Platform can use TraceHubLib to consume the HOB.
________________________________
From: Ni, Ray <ray.ni at intel.com<mailto:ray.ni at intel.com>>
Sent: Wednesday, June 21, 2023 9:25:08 PM
To: Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>>; Hsu, VictorX <victorx.hsu at intel.com<mailto:victorx.hsu at intel.com>>
Cc: Gao, Liming <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>; Chan Laura <laura.chan at intel.com<mailto:laura.chan at intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan at intel.com<mailto:krishnadas.veliyathuparambil.prakashan at intel.com>>; K N, Karthik <karthik.k.n at intel.com<mailto:karthik.k.n at intel.com>>
Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg


I don’t think that’s the solution to resolve pkg dependencies by adding interfaces to mdePkg.



From: Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>
Sent: Wednesday, June 21, 2023 9:23 PM
To: Ni, Ray <ray.ni at intel.com<mailto:ray.ni at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>; Hsu, VictorX <victorx.hsu at intel.com<mailto:victorx.hsu at intel.com>>
Cc: Gao, Liming <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>; Chan Laura <laura.chan at intel.com<mailto:laura.chan at intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan at intel.com<mailto:krishnadas.veliyathuparambil.prakashan at intel.com>>; K N, Karthik <karthik.k.n at intel.com<mailto:karthik.k.n at intel.com>>
Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg



Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg.

________________________________

From: Ni, Ray <ray.ni at intel.com<mailto:ray.ni at intel.com>>
Sent: Wednesday, June 21, 2023 9:20:23 PM
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>>; Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>; Hsu, VictorX <victorx.hsu at intel.com<mailto:victorx.hsu at intel.com>>
Cc: Gao, Liming <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>; Chan Laura <laura.chan at intel.com<mailto:laura.chan at intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan at intel.com<mailto:krishnadas.veliyathuparambil.prakashan at intel.com>>; K N, Karthik <karthik.k.n at intel.com<mailto:karthik.k.n at intel.com>>
Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg



Why is this GUID moved to MdePkg?

> -----Original Message-----
> From: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>> On Behalf Of Guo, Gua
> Sent: Wednesday, June 21, 2023 3:02 PM
> To: Hsu, VictorX <victorx.hsu at intel.com<mailto:victorx.hsu at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>
> Cc: Gao, Liming <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>; Chan Laura
> <laura.chan at intel.com<mailto:laura.chan at intel.com>>; Prakashan, Krishnadas Veliyathuparambil
> <krishnadas.veliyathuparambil.prakashan at intel.com<mailto:krishnadas.veliyathuparambil.prakashan at intel.com>>; K N, Karthik
> <karthik.k.n at intel.com<mailto:karthik.k.n at intel.com>>
> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move
> gTraceHubDebugInfoHobGuid to MdePkg
>
> Reviewed-by: Gua Guo <gua.guo at intel.com<mailto:gua.guo at intel.com>>
>
> -----Original Message-----
> From: Hsu, VictorX <victorx.hsu at intel.com<mailto:victorx.hsu at intel.com>>
> Sent: Wednesday, June 21, 2023 3:01 PM
> To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>
> Cc: Hsu, VictorX <victorx.hsu at intel.com<mailto:victorx.hsu at intel.com>>; Gao, Liming
> <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>; Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>; Chan Laura
> <laura.chan at intel.com<mailto:laura.chan at intel.com>>; Prakashan, Krishnadas Veliyathuparambil
> <krishnadas.veliyathuparambil.prakashan at intel.com<mailto:krishnadas.veliyathuparambil.prakashan at intel.com>>; K N, Karthik
> <karthik.k.n at intel.com<mailto:karthik.k.n at intel.com>>
> Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg
>
> From: VictorX Hsu <victorx.hsu at intel.com<mailto:victorx.hsu at intel.com>>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486
>
> Move gTraceHubDebugInfoHobGuid to MdePkg.
>
> Cc: Liming Gao <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>
> Cc: Guo Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>
> Cc: Chan Laura <laura.chan at intel.com<mailto:laura.chan at intel.com>>
> Cc: Prakashan Krishnadas Veliyathuparambil
> <krishnadas.veliyathuparambil.prakashan at intel.com<mailto:krishnadas.veliyathuparambil.prakashan at intel.com>>
> Cc: K N Karthik <karthik.k.n at intel.com<mailto:karthik.k.n at intel.com>>
> Signed-off-by: VictorX Hsu <victorx.hsu at intel.com<mailto:victorx.hsu at intel.com>>
> ---
>  MdeModulePkg/MdeModulePkg.dec                               | 3 ---
>  .../Include/Guid/TraceHubDebugInfoHob.h                     | 0
>  MdePkg/MdePkg.dec                                           | 6 ++++++
>  3 files changed, 6 insertions(+), 3 deletions(-)  rename {MdeModulePkg =>
> MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f
> 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -439,9 +439,6 @@
>    ## Include/UniversalPayload/SerialPortInfo.h
> gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e,
> 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } -  ##
> Include/Guid/TraceHubDebugInfoHob.h-  gTraceHubDebugInfoHobGuid =
> { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08,
> 0x35 } }-   ## GUID used for Boot Discovery Policy FormSet guid and related
> variables.   gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c,
> 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git
> a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h
> b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h
> similarity index 100%
> rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h
> rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> b85614992b..3b5d1bac13 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -875,6 +875,12 @@
>    ## Include/Protocol/CcMeasurement.h   gEfiCcFinalEventsTableGuid     =
> { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4,
> 0x46 }} +  #+  # GUID used to store Trace Hub Debug information+  #+  ##
> Include/Guid/TraceHubDebugInfoHob.h+  gTraceHubDebugInfoHobGuid =
> { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08,
> 0x35 } }+ [Guids.IA32, Guids.X64]   ## Include/Guid/Cper.h
> gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de,
> { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}--
> 2.40.0.windows.1
>
>
>
>
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106413): https://edk2.groups.io/g/devel/message/106413
Mute This Topic: https://groups.io/mt/99801806/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20230627/2c1a27c1/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 39448 bytes
Desc: image001.png
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20230627/2c1a27c1/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.png
Type: image/png
Size: 240189 bytes
Desc: image002.png
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20230627/2c1a27c1/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image003.png
Type: image/png
Size: 10213 bytes
Desc: image003.png
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20230627/2c1a27c1/attachment-0005.png>

More information about the edk2-devel-archive mailing list