[edk2-devel] [edk2 2/2] MdePkg: add BaseSerialPortLibRiscVSbi

[Andrei Warkentin]

Hi Michael,

What module type should I use instead? The reason being this SerialPortLib implementation specifically fits into the class of UEFI implementations, where RAM is always available (initialized by something else prior to Tiano) and non-const globals can be used (e.g. PrePi).

A

-----Original Message-----
From: Kinney, Michael D <michael.d.kinney at intel.com> 
Sent: Wednesday, March 1, 2023 10:56 AM
To: devel at edk2.groups.io; kraxel at redhat.com; Warkentin, Andrei <andrei.warkentin at intel.com>
Cc: Daniel Schaefer <git at danielschaefer.me>; Sunil V L <sunilvl at ventanamicro.com>; Kinney, Michael D <michael.d.kinney at intel.com>
Subject: RE: [edk2-devel] [edk2 2/2] MdePkg: add BaseSerialPortLibRiscVSbi

Using a global is not compatible with XIP code where only const globals are supported.

A module of type BASE is considered compatible with XIP components.


Mike

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Gerd Hoffmann
> Sent: Wednesday, March 1, 2023 1:07 AM
> To: Warkentin, Andrei <andrei.warkentin at intel.com>
> Cc: devel at edk2.groups.io; Daniel Schaefer <git at danielschaefer.me>; Sunil V L <sunilvl at ventanamicro.com>
> Subject: Re: [edk2-devel] [edk2 2/2] MdePkg: add BaseSerialPortLibRiscVSbi
> 
> On Wed, Mar 01, 2023 at 08:50:38AM +0000, Warkentin, Andrei wrote:
> > The library caller could call Poll() first,
> 
> Ah, Poll is part of the library API, not just an internal helper.
> Ok, makes sense then.
> 
> series:
> Acked-by: Gerd Hoffmann <kraxel at redhat.com>
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100601): https://edk2.groups.io/g/devel/message/100601
Mute This Topic: https://groups.io/mt/97309875/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-