[edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB aligned

[Ni, Ray]

Agree with both comments😊

> -----Original Message-----
> From: Gerd Hoffmann <kraxel at redhat.com>
> Sent: Monday, March 13, 2023 4:00 PM
> To: Tom Lendacky <thomas.lendacky at amd.com>
> Cc: devel at edk2.groups.io; Dong, Eric <eric.dong at intel.com>; Ni, Ray
> <ray.ni at intel.com>; Kumar, Rahul R <rahul.r.kumar at intel.com>; Michael
> Roth <michael.roth at amd.com>; Ashish Kalra <Ashish.Kalra at amd.com>
> Subject: Re: [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA
> allocations are not 2MB aligned
> 
>   Hi,
> 
> >    // Allocate a single page for the SEV-ES Save Area and initialize it.
> > +  // Due to an erratum that prevents a VMSA being on a 2MB boundary,
> > +  // allocate an extra page to work around the issue.
> 
> A reference to the erratum (web link or erratum id) would be nice here.
> Also swapping the order of the two patches might simplify the other
> patch which happens to shuffle around the code this patch has just
> added.
> 
> take care,
>   Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101082): https://edk2.groups.io/g/devel/message/101082
Mute This Topic: https://groups.io/mt/97524218/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3943202/1813853/130120423/xyzzy [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-