[edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure
Michael D Kinney
michael.d.kinney at intel.com
Sun Mar 26 02:04:45 UTC 2023
Merged: https://github.com/tianocore/edk2/pull/4181
Commit: https://github.com/tianocore/edk2/commit/07fa6d1841abcfc58b226027d711ebb47559f442
Mike
From: Kinney, Michael D <michael.d.kinney at intel.com>
Sent: Saturday, March 25, 2023 6:05 PM
To: Pawel Polawski <ppolawsk at redhat.com>
Cc: devel at edk2.groups.io; Gao, Liming <gaoliming at byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu at intel.com>; Zimmer, Vincent <vincent.zimmer at intel.com>; Kinney, Michael D <michael.d.kinney at intel.com>
Subject: RE: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure
Thanks Pawel,
I see there were some minor CI issues related to uncrustify formatting.
I am fixing those and will post a new PR with my Rb.
I will close 4174.
Mike
From: Pawel Polawski <ppolawsk at redhat.com>
Sent: Friday, March 24, 2023 7:46 AM
To: Kinney, Michael D <michael.d.kinney at intel.com>
Cc: devel at edk2.groups.io; Gao, Liming <gaoliming at byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu at intel.com>; Zimmer, Vincent <vincent.zimmer at intel.com>
Subject: Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure
Hi Michael,
Sorry for the delay in my response. I just opened PR against EDK2 repo to trigger CI:
https://github.com/tianocore/edk2/pull/4174
Best regards,
Pawel
On Thu, Mar 23, 2023 at 11:10 PM Kinney, Michael D <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>> wrote:
Hi Pawel,
Any updates on this task?
I would like to see this go in soon so it can get some flight time before next stable tag.
Mike
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>
> Sent: Tuesday, March 7, 2023 2:25 PM
> To: Paweł Poławski <ppolawsk at redhat.com<mailto:ppolawsk at redhat.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>
> Cc: Gao, Liming <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>; Liu, Zhiguang <zhiguang.liu at intel.com<mailto:zhiguang.liu at intel.com>>; Zimmer, Vincent <vincent.zimmer at intel.com<mailto:vincent.zimmer at intel.com>>;
> Kinney, Michael D <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>
> Subject: RE: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure
>
> Hi Pawel,
>
> Can you please also reference the following BZ and commit in the commit message
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1560
> https://github.com/tianocore/edk2/commit/4e1daa60f5372c22a11503961061ffa569eaf873
>
> If you post a branch with these small updates and my Rb and send it
> through EDK II CI, I can do the push from there.
>
> Thanks,
>
> Mike
>
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>
> > Sent: Tuesday, March 7, 2023 1:59 PM
> > To: Paweł Poławski <ppolawsk at redhat.com<mailto:ppolawsk at redhat.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>
> > Cc: Gao, Liming <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>; Liu, Zhiguang <zhiguang.liu at intel.com<mailto:zhiguang.liu at intel.com>>; Zimmer, Vincent
> > <vincent.zimmer at intel.com<mailto:vincent.zimmer at intel.com>>; Kinney, Michael D <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>
> > Subject: RE: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure
> >
> > Hi Pawel,
> >
> > With suggestion from Vincent, let's remove ItaniumHealthFlags.
> >
> > https://edk2.groups.io/g/devel/message/100812
> >
> > I recommend adding a note in the comment block for the
> > EFI_SEC_PLATFORM_INFORMATION_RECORD that with the removal of the
> > ItaniumHealthFlags, this union has diverged from the PI
> > Specification definition.
> >
> > With that one comment addition:
> >
> > Reviewed-by: Michael D Kinney <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>
> >
> > Mike
> >
> >
> > > -----Original Message-----
> > > From: Paweł Poławski <ppolawsk at redhat.com<mailto:ppolawsk at redhat.com>>
> > > Sent: Thursday, December 1, 2022 7:36 AM
> > > To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>
> > > Cc: Kinney, Michael D <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>; Gao, Liming <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>; Liu, Zhiguang
> > > <zhiguang.liu at intel.com<mailto:zhiguang.liu at intel.com>>
> > > Subject: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure
> > >
> > > Itanium support has been removed from EDK2 aroun 2019.
> > > ITANIUM_HANDOFF_STATUS data structure looks to be
> > > some leftover from that process.
> > >
> > > There is also positive sidefect of this data structure removal.
> > > Due to HOB allocation type used in PEI stage there is a limit
> > > how much data about virtual CPU can be hold. This limit result
> > > in only 1024 vCPU can be used by VM.
> > > With Itanium related data structure removed more allocated space
> > > can be used for vCPU data and with current allocation limit
> > > will change from 1024 to around 8k vCPUs.
> > >
> > > Cc: Michael D Kinney <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>
> > > Cc: Liming Gao <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>
> > > Cc: Zhiguang Liu <zhiguang.liu at intel.com<mailto:zhiguang.liu at intel.com>>
> > >
> > > Signed-off-by: Paweł Poławski <ppolawsk at redhat.com<mailto:ppolawsk at redhat.com>>
> > > ---
> > > MdePkg/Include/Ppi/SecPlatformInformation.h | 44 --------------------
> > > 1 file changed, 44 deletions(-)
> > >
> > > diff --git a/MdePkg/Include/Ppi/SecPlatformInformation.h b/MdePkg/Include/Ppi/SecPlatformInformation.h
> > > index 02b0711f189e..fbcd205acd96 100644
> > > --- a/MdePkg/Include/Ppi/SecPlatformInformation.h
> > > +++ b/MdePkg/Include/Ppi/SecPlatformInformation.h
> > > @@ -84,49 +84,6 @@ typedef union {
> > >
> > > typedef EFI_HEALTH_FLAGS X64_HANDOFF_STATUS;
> > > typedef EFI_HEALTH_FLAGS IA32_HANDOFF_STATUS;
> > > -///
> > > -/// The hand-off status structure for Itanium architecture.
> > > -///
> > > -typedef struct {
> > > - ///
> > > - /// SALE_ENTRY state : 3 = Recovery_Check
> > > - /// and 0 = RESET or Normal_Boot phase.
> > > - ///
> > > - UINT8 BootPhase;
> > > - ///
> > > - /// Firmware status on entry to SALE.
> > > - ///
> > > - UINT8 FWStatus;
> > > - UINT16 Reserved1;
> > > - UINT32 Reserved2;
> > > - ///
> > > - /// Geographically significant unique processor ID assigned by PAL.
> > > - ///
> > > - UINT16 ProcId;
> > > - UINT16 Reserved3;
> > > - UINT8 IdMask;
> > > - UINT8 EidMask;
> > > - UINT16 Reserved4;
> > > - ///
> > > - /// Address to make PAL calls.
> > > - ///
> > > - UINT64 PalCallAddress;
> > > - ///
> > > - /// If the entry state is RECOVERY_CHECK, this contains the PAL_RESET
> > > - /// return address, and if entry state is RESET, this contains
> > > - /// address for PAL_authentication call.
> > > - ///
> > > - UINT64 PalSpecialAddress;
> > > - ///
> > > - /// GR35 from PALE_EXIT state.
> > > - ///
> > > - UINT64 SelfTestStatus;
> > > - ///
> > > - /// GR37 from PALE_EXIT state.
> > > - ///
> > > - UINT64 SelfTestControl;
> > > - UINT64 MemoryBufferRequired;
> > > -} ITANIUM_HANDOFF_STATUS;
> > >
> > > ///
> > > /// EFI_SEC_PLATFORM_INFORMATION_RECORD.
> > > @@ -134,7 +91,6 @@ typedef struct {
> > > typedef union {
> > > IA32_HANDOFF_STATUS IA32HealthFlags;
> > > X64_HANDOFF_STATUS x64HealthFlags;
> > > - ITANIUM_HANDOFF_STATUS ItaniumHealthFlags;
> > > } EFI_SEC_PLATFORM_INFORMATION_RECORD;
> > >
> > > /**
> > > --
> > > 2.38.1
--
Paweł Poławski
Red Hat<https://www.redhat.com/> Virtualization
ppolawsk at redhat.com<mailto:ppolawsk at redhat.com>
@RedHat<https://twitter.com/redhat> Red Hat<https://www.linkedin.com/company/red-hat> Red Hat<https://www.facebook.com/RedHatInc>
[https://static.redhat.com/libs/redhat/brand-assets/latest/corp/logo.png]<https://red.ht/sig>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101890): https://edk2.groups.io/g/devel/message/101890
Mute This Topic: https://groups.io/mt/95384808/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3943202/1813853/130120423/xyzzy [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20230326/6a99ceea/attachment-0001.htm>
More information about the edk2-devel-archive
mailing list