[edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

[Sami Mujawar]

Hi Jianyong,

Thank you for this fix.

The subject line should have the package name as prefix followed by the short description for the patch e.g. "ArmVirtPkg: xxx".
Other than that, this change looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>

Regards,

Sami Mujawar

On 28/03/2023, 04:28, "Jianyong Wu" <Jianyong.Wu at arm.com <mailto:Jianyong.Wu at arm.com>> wrote:


Add Ard Biesheuvel <ardb at kernel.org <mailto:ardb at kernel.org>> and Sunil V L <sunilvl at ventanamicro.com <mailto:sunilvl at ventanamicro.com>> to cc list.


> -----Original Message-----
> From: Jianyong Wu <jianyong.wu at arm.com <mailto:jianyong.wu at arm.com>>
> Sent: 2023年2月17日 14:48
> To: devel at edk2.groups.io <mailto:devel at edk2.groups.io>; Sami Mujawar <Sami.Mujawar at arm.com <mailto:Sami.Mujawar at arm.com>>
> Cc: Jianyong Wu <Jianyong.Wu at arm.com <mailto:Jianyong.Wu at arm.com>>
> Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
>
> commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
> missing in CloudHvHasAcpiDtDxe.inf which leads to
> gUefiOvmfPkgTokenSpaceGuid found nowhere.
>
> Signed-off-by: Jianyong Wu <jianyong.wu at arm.com <mailto:jianyong.wu at arm.com>>
> ---
> ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> index 7cad40e11f..6ff80b24d0 100644
> --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> @@ -23,6 +23,7 @@
> EmbeddedPkg/EmbeddedPkg.dec
> MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> + OvmfPkg/OvmfPkg.dec
>
> [LibraryClasses]
> BaseLib
> --
> 2.17.1





IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102015): https://edk2.groups.io/g/devel/message/102015
Mute This Topic: https://groups.io/mt/97023835/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-