[edk2-devel] [PATCH 2/6] UefiCpuPkg/MtrrTest: Only claim CPUID max leaf as 1

Michael D Kinney michael.d.kinney at intel.com
Wed Mar 29 22:22:07 UTC 2023


Reviewed-by: Michael D Kinney <michael.d.kinney at intel.com>

> -----Original Message-----
> From: Ni, Ray <ray.ni at intel.com>
> Sent: Tuesday, March 21, 2023 4:57 PM
> To: devel at edk2.groups.io
> Cc: Dong, Eric <eric.dong at intel.com>; Kumar, Rahul R <rahul.r.kumar at intel.com>; Gerd Hoffmann <kraxel at redhat.com>; Kinney,
> Michael D <michael.d.kinney at intel.com>; Anadani, Ahmad <ahmad.anadani at intel.com>
> Subject: [PATCH 2/6] UefiCpuPkg/MtrrTest: Only claim CPUID max leaf as 1
> 
> MtrrLib code queries the CPUID leaf 7h result if support.
> Update Test code temporary to claim the CPUID only
> supports max leaf as 1 so MtrrLib skips to query CPUID leaf 7h.
> 
> Signed-off-by: Ray Ni <ray.ni at intel.com>
> Cc: Eric Dong <eric.dong at intel.com>
> Cc: Rahul Kumar <rahul1.kumar at intel.com>
> Cc: Gerd Hoffmann <kraxel at redhat.com>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Cc: Ahmad Anadani <ahmad.anadani at intel.com>
> ---
>  UefiCpuPkg/Library/MtrrLib/UnitTest/Support.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/Library/MtrrLib/UnitTest/Support.c b/UefiCpuPkg/Library/MtrrLib/UnitTest/Support.c
> index 748c403281..260966e7b6 100644
> --- a/UefiCpuPkg/Library/MtrrLib/UnitTest/Support.c
> +++ b/UefiCpuPkg/Library/MtrrLib/UnitTest/Support.c
> @@ -1,7 +1,7 @@
>  /** @file
> 
>    Unit tests of the MtrrLib instance of the MtrrLib class
> 
> 
> 
> -  Copyright (c) 2018 - 2020, Intel Corporation. All rights reserved.<BR>
> 
> +  Copyright (c) 2018 - 2023, Intel Corporation. All rights reserved.<BR>
> 
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> 
> 
>  **/
> 
> @@ -122,6 +122,13 @@ UnitTestMtrrLibAsmCpuid (
>    )
> 
>  {
> 
>    switch (Index) {
> 
> +    case CPUID_SIGNATURE:
> 
> +      if (Eax != NULL) {
> 
> +        *Eax = CPUID_VERSION_INFO;
> 
> +      }
> 
> +
> 
> +      return Index;
> 
> +      break;
> 
>      case CPUID_VERSION_INFO:
> 
>        if (Edx != NULL) {
> 
>          *Edx = mCpuidVersionInfoEdx.Uint32;
> 
> --
> 2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102136): https://edk2.groups.io/g/devel/message/102136
Mute This Topic: https://groups.io/mt/97767968/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3943202/1813853/130120423/xyzzy [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list