[edk2-devel] [PATCH V2 2/5] RedfishPkg: Fix condition checking of error status

[Nickle Wang via groups.io]

Thanks for fixing this issue.

Reviewed-by: Nickle Wang <nicklew at nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: Minh Nguyen <minhnguyen1 at os.amperecomputing.com>
> Sent: Thursday, May 4, 2023 12:20 PM
> To: devel at edk2.groups.io
> Cc: patches at amperecomputing.com; abner.chang at amd.com; Nickle Wang
> <nicklew at nvidia.com>; igork at ami.com; nhi at os.amperecomputing.com; Vu
> Nguyen <vunguyen at os.amperecomputing.com>; Minh Nguyen
> <minhnguyen1 at os.amperecomputing.com>; Nick Ramirez
> <nramirez at nvidia.com>
> Subject: [PATCH V2 2/5] RedfishPkg: Fix condition checking of error status
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Vu Nguyen <vunguyen at os.amperecomputing.com>
> 
> This change fixes condition checking of error status, the condition should be
> compared with TRUE status to be identical with an error message.
> 
> Signed-off-by: Minh Nguyen <minhnguyen1 at os.amperecomputing.com>
> Cc: Abner Chang <abner.chang at amd.com>
> Cc: Igor Kulchytskyy <igork at ami.com>
> Cc: Nick Ramirez <nramirez at nvidia.com>
> ---
>  RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> index 583c6f78e19c..a247bfed9e34 100644
> --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> @@ -5,6 +5,7 @@
>    (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
>    Copyright (c) 2022, AMD Incorporated. All rights reserved.
>    Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> +  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
> 
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> @@ -926,7 +927,7 @@ AddAndSignalNewRedfishService (
>      }
> 
>      Status = gBS->SignalEvent (Instance->DiscoverToken->Event);
> -    if (!EFI_ERROR (Status)) {
> +    if (EFI_ERROR (Status)) {
>        DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__));
>      }
>    }
> --
> 2.39.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103971): https://edk2.groups.io/g/devel/message/103971
Mute This Topic: https://groups.io/mt/98678064/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-