[edk2-devel] [PATCH v6 08/16] Add GCC and GCCNOLTO toolchains to tools_def.txt and update packages
Yao, Jiewen
jiewen.yao at intel.com
Fri May 5 02:02:51 UTC 2023
Thanks Liming.
I am not sure below change is expected or not. Please feedback if possible. Thank you!
> Why we add "-flto" for "NOLTO" ?
>>> + *_GCCNOLTO_IA32_CC_FLAGS = -flto
>>> + *_GCCNOLTO_IA32_DLINK_FLAGS = -flto
> -----Original Message-----
> From: gaoliming <gaoliming at byosoft.com.cn>
> Sent: Friday, May 5, 2023 10:00 AM
> To: devel at edk2.groups.io; rebecca at bsdio.com; Yao, Jiewen
> <jiewen.yao at intel.com>; Wang, Jian J <jian.j.wang at intel.com>; Lu, Xiaoyu1
> <xiaoyu1.lu at intel.com>; Jiang, Guomin <guomin.jiang at intel.com>; 'Andrew
> Fish' <afish at apple.com>; Ni, Ray <ray.ni at intel.com>; Chiu, Chasel
> <chasel.chiu at intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>; Zeng, Star <star.zeng at intel.com>
> Subject: 回复: [edk2-devel] [PATCH v6 08/16] Add GCC and GCCNOLTO
> toolchains to tools_def.txt and update packages
>
> Rebecca:
> I understand this change is to add GCC and GCCNOLTO toolchain. GCC is
> same to GCC5, GCCNOLTO is same to GCC49. So, new tool chain copies the
> same changes from origin one. Right?
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 Rebecca
> Cran
> > 发送时间: 2023年5月2日 22:23
> > 收件人: Yao, Jiewen <jiewen.yao at intel.com>; devel at edk2.groups.io;
> Wang,
> > Jian J <jian.j.wang at intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu at intel.com>; Jiang,
> > Guomin <guomin.jiang at intel.com>; Andrew Fish <afish at apple.com>; Ni,
> Ray
> > <ray.ni at intel.com>; Chiu, Chasel <chasel.chiu at intel.com>; Desimone,
> > Nathaniel L <nathaniel.l.desimone at intel.com>; Zeng, Star
> > <star.zeng at intel.com>
> > 主题: Re: [edk2-devel] [PATCH v6 08/16] Add GCC and GCCNOLTO
> toolchains
> > to tools_def.txt and update packages
> >
> > On 5/2/23 00:35, Yao, Jiewen wrote:
> > > Have you evaluated size impact with this new compiler option? Especially
> > crypto library.
> > > Bigger? Smaller?
> >
> > The increase in size when we disable LTO doesn't seem too bad:
> >
> > With LTO:
> >
> > -rwxrwxr-x 1 bcran bcran 13M May 2 08:11
> > CryptoDxe_41A491D1-A972-468B-A299-DABF415A43B7.debug
> > -rwxrwxr-x 1 bcran bcran 13M May 2 08:11
> > CryptoDxe_AA83B296-F6EA-447F-B013-E80E98629CF8.debug
> > -rwxrwxr-x 1 bcran bcran 11M May 2 08:11
> > CryptoDxe_9FBDAD27-910C-4229-9EFF-A93BB5FE18C6.debug
> > -rwxrwxr-x 1 bcran bcran 11M May 2 08:11
> > CryptoDxe_ADD6D05A-52A2-437B-98E7-DBFDA89352CD.debug
> > -rwxrwxr-x 1 bcran bcran 8.5M May 2 08:11
> > CryptoSmm_C1760694-AB3A-4532-8C6D-52D8F86EB1AA.debug
> > -rwxrwxr-x 1 bcran bcran 8.3M May 2 08:11
> > CryptoSmm_1930CE7E-6598-48ED-8AB1-EBE7E85EC254.debug
> > -rwxrwxr-x 1 bcran bcran 8.0M May 2 08:11
> > CryptoPei_A10827AD-7598-4955-B661-52EE2B62B057.debug
> > -rwxrwxr-x 1 bcran bcran 7.8M May 2 08:11
> > CryptoPei_D51FCE59-6860-49C0-9B35-984470735D17.debug
> > -rwxrwxr-x 1 bcran bcran 7.0M May 2 08:11
> > BaseCryptLibUnitTestShell.debug
> > -rwxrwxr-x 1 bcran bcran 7.0M May 2 08:11
> > CryptoSmm_828959D3-CEA6-4B79-B1FC-5AFA0D7F2144.debug
> > -rwxrwxr-x 1 bcran bcran 6.9M May 2 08:11
> > CryptoDxe_31C17C54-325D-47D5-8622-888098F10E44.debug
> > -rwxrwxr-x 1 bcran bcran 6.7M May 2 08:11
> > CryptoSmm_E4D7D1E3-E886-4412-A442-EFD6F2502DD3.debug
> > -rwxrwxr-x 1 bcran bcran 6.7M May 2 08:11
> > CryptoSmm_1A1C9E13-5722-4636-AB73-31328EDE8BAF.debug
> > -rwxrwxr-x 1 bcran bcran 6.5M May 2 08:11
> > CryptoPei_DCC9CB49-7BE2-47C6-864E-6DCC932360F9.debug
> > -rwxrwxr-x 1 bcran bcran 6.2M May 2 08:11
> > CryptoPei_EBD49F5C-6D8B-40D1-A56D-9AFA485A8661.debug
> > -rwxrwxr-x 1 bcran bcran 6.2M May 2 08:11
> > CryptoPei_C693A250-6B36-49B9-B7F3-7283F8136A72.debug
> > -rw-rw-r-- 1 bcran bcran 1005K May 2 08:11
> > CryptoDxe_41A491D1-A972-468B-A299-DABF415A43B7.efi
> > -rw-rw-r-- 1 bcran bcran 903K May 2 08:11
> > CryptoDxe_AA83B296-F6EA-447F-B013-E80E98629CF8.efi
> > -rw-rw-r-- 1 bcran bcran 811K May 2 08:11
> > CryptoDxe_9FBDAD27-910C-4229-9EFF-A93BB5FE18C6.efi
> > -rw-rw-r-- 1 bcran bcran 755K May 2 08:11
> > CryptoSmm_C1760694-AB3A-4532-8C6D-52D8F86EB1AA.efi
> > -rw-rw-r-- 1 bcran bcran 724K May 2 08:11
> > CryptoPei_A10827AD-7598-4955-B661-52EE2B62B057.efi
> > -rw-rw-r-- 1 bcran bcran 710K May 2 08:11
> > CryptoDxe_ADD6D05A-52A2-437B-98E7-DBFDA89352CD.efi
> > -rw-rw-r-- 1 bcran bcran 654K May 2 08:11
> > CryptoSmm_1930CE7E-6598-48ED-8AB1-EBE7E85EC254.efi
> > -rw-rw-r-- 1 bcran bcran 623K May 2 08:11
> > CryptoPei_D51FCE59-6860-49C0-9B35-984470735D17.efi
> > -rw-rw-r-- 1 bcran bcran 585K May 2 08:11
> > CryptoSmm_828959D3-CEA6-4B79-B1FC-5AFA0D7F2144.efi
> > -rw-rw-r-- 1 bcran bcran 560K May 2 08:11 BaseCryptLibUnitTestShell.efi
> > -rw-rw-r-- 1 bcran bcran 555K May 2 08:11
> > CryptoPei_DCC9CB49-7BE2-47C6-864E-6DCC932360F9.efi
> > -rw-rw-r-- 1 bcran bcran 500K May 2 08:11
> > CryptoDxe_31C17C54-325D-47D5-8622-888098F10E44.efi
> > -rw-rw-r-- 1 bcran bcran 485K May 2 08:11
> > CryptoSmm_1A1C9E13-5722-4636-AB73-31328EDE8BAF.efi
> > -rw-rw-r-- 1 bcran bcran 485K May 2 08:11
> > CryptoSmm_E4D7D1E3-E886-4412-A442-EFD6F2502DD3.efi
> > -rw-rw-r-- 1 bcran bcran 454K May 2 08:11
> > CryptoPei_C693A250-6B36-49B9-B7F3-7283F8136A72.efi
> > -rw-rw-r-- 1 bcran bcran 454K May 2 08:11
> > CryptoPei_EBD49F5C-6D8B-40D1-A56D-9AFA485A8661.efi
> >
> > Without LTO:
> > -rwxrwxr-x 1 bcran bcran 14M May 2 08:13
> > CryptoDxe_41A491D1-A972-468B-A299-DABF415A43B7.debug
> > -rwxrwxr-x 1 bcran bcran 14M May 2 08:13
> > CryptoDxe_AA83B296-F6EA-447F-B013-E80E98629CF8.debug
> > -rwxrwxr-x 1 bcran bcran 12M May 2 08:13
> > CryptoDxe_9FBDAD27-910C-4229-9EFF-A93BB5FE18C6.debug
> > -rwxrwxr-x 1 bcran bcran 12M May 2 08:13
> > CryptoDxe_ADD6D05A-52A2-437B-98E7-DBFDA89352CD.debug
> > -rwxrwxr-x 1 bcran bcran 9.5M May 2 08:13
> > CryptoSmm_C1760694-AB3A-4532-8C6D-52D8F86EB1AA.debug
> > -rwxrwxr-x 1 bcran bcran 9.2M May 2 08:13
> > CryptoSmm_1930CE7E-6598-48ED-8AB1-EBE7E85EC254.debug
> > -rwxrwxr-x 1 bcran bcran 8.9M May 2 08:13
> > CryptoPei_A10827AD-7598-4955-B661-52EE2B62B057.debug
> > -rwxrwxr-x 1 bcran bcran 8.7M May 2 08:13
> > CryptoPei_D51FCE59-6860-49C0-9B35-984470735D17.debug
> > -rwxrwxr-x 1 bcran bcran 8.0M May 2 08:13
> > CryptoSmm_828959D3-CEA6-4B79-B1FC-5AFA0D7F2144.debug
> > -rwxrwxr-x 1 bcran bcran 7.9M May 2 08:13
> > BaseCryptLibUnitTestShell.debug
> > -rwxrwxr-x 1 bcran bcran 7.9M May 2 08:12
> > CryptoDxe_31C17C54-325D-47D5-8622-888098F10E44.debug
> > -rwxrwxr-x 1 bcran bcran 7.7M May 2 08:12
> > CryptoSmm_1A1C9E13-5722-4636-AB73-31328EDE8BAF.debug
> > -rwxrwxr-x 1 bcran bcran 7.7M May 2 08:13
> > CryptoSmm_E4D7D1E3-E886-4412-A442-EFD6F2502DD3.debug
> > -rwxrwxr-x 1 bcran bcran 7.4M May 2 08:13
> > CryptoPei_DCC9CB49-7BE2-47C6-864E-6DCC932360F9.debug
> > -rwxrwxr-x 1 bcran bcran 7.2M May 2 08:12
> > CryptoPei_C693A250-6B36-49B9-B7F3-7283F8136A72.debug
> > -rwxrwxr-x 1 bcran bcran 7.2M May 2 08:13
> > CryptoPei_EBD49F5C-6D8B-40D1-A56D-9AFA485A8661.debug
> > -rw-rw-r-- 1 bcran bcran 1.1M May 2 08:13
> > CryptoDxe_41A491D1-A972-468B-A299-DABF415A43B7.efi
> > -rw-rw-r-- 1 bcran bcran 1011K May 2 08:13
> > CryptoDxe_AA83B296-F6EA-447F-B013-E80E98629CF8.efi
> > -rw-rw-r-- 1 bcran bcran 914K May 2 08:13
> > CryptoDxe_9FBDAD27-910C-4229-9EFF-A93BB5FE18C6.efi
> > -rw-rw-r-- 1 bcran bcran 823K May 2 08:13
> > CryptoSmm_C1760694-AB3A-4532-8C6D-52D8F86EB1AA.efi
> > -rw-rw-r-- 1 bcran bcran 813K May 2 08:13
> > CryptoDxe_ADD6D05A-52A2-437B-98E7-DBFDA89352CD.efi
> > -rw-rw-r-- 1 bcran bcran 789K May 2 08:13
> > CryptoPei_A10827AD-7598-4955-B661-52EE2B62B057.efi
> > -rw-rw-r-- 1 bcran bcran 722K May 2 08:13
> > CryptoSmm_1930CE7E-6598-48ED-8AB1-EBE7E85EC254.efi
> > -rw-rw-r-- 1 bcran bcran 687K May 2 08:13
> > CryptoPei_D51FCE59-6860-49C0-9B35-984470735D17.efi
> > -rw-rw-r-- 1 bcran bcran 644K May 2 08:13
> > CryptoSmm_828959D3-CEA6-4B79-B1FC-5AFA0D7F2144.efi
> > -rw-rw-r-- 1 bcran bcran 632K May 2 08:13 BaseCryptLibUnitTestShell.efi
> > -rw-rw-r-- 1 bcran bcran 610K May 2 08:13
> > CryptoPei_DCC9CB49-7BE2-47C6-864E-6DCC932360F9.efi
> > -rw-rw-r-- 1 bcran bcran 567K May 2 08:12
> > CryptoDxe_31C17C54-325D-47D5-8622-888098F10E44.efi
> > -rw-rw-r-- 1 bcran bcran 543K May 2 08:12
> > CryptoSmm_1A1C9E13-5722-4636-AB73-31328EDE8BAF.efi
> > -rw-rw-r-- 1 bcran bcran 543K May 2 08:13
> > CryptoSmm_E4D7D1E3-E886-4412-A442-EFD6F2502DD3.efi
> > -rw-rw-r-- 1 bcran bcran 508K May 2 08:12
> > CryptoPei_C693A250-6B36-49B9-B7F3-7283F8136A72.efi
> > -rw-rw-r-- 1 bcran bcran 508K May 2 08:13
> > CryptoPei_EBD49F5C-6D8B-40D1-A56D-9AFA485A8661.efi
> >
> > >
> > > Why we add "-flto" for "NOLTO" ?
> > >>> + *_GCCNOLTO_IA32_CC_FLAGS = -flto
> > >>> + *_GCCNOLTO_IA32_DLINK_FLAGS = -flto
> >
> > I don't know why -flto was added for the GCC49 flags, but when I created
> > the GCCNOLTO flags I copied it because I presume there's a reason this
> > specific test package requires it.
> >
> >
> > --
> >
> > Rebecca Cran
> >
> >
> >
> >
> >
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104072): https://edk2.groups.io/g/devel/message/104072
Mute This Topic: https://groups.io/mt/98697642/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list