[edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

[Minh Nguyen]

Hi Abner,

  While they're checking this issue, they recommend me to re-send v3 so 
I just sent it, you can also use the PR to review at the same time.

Thanks,

Minh Nguyen.

On 5/5/2023 1:01 PM, Minh Nguyen wrote:
>
> Hi Abner,
>
>  Here you are: #4338 <https://github.com/tianocore/edk2/pull/4338>
>
> Thanks,
>
> Minh Nguyen
>
> On 5/5/2023 12:45 PM, Chang, Abner wrote:
>> [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.]
>>
>>
>> [AMD Official Use Only - General]
>>
>> Ok, because the patch in email always has format problem when apply the patch, plus I can't get the patch from group.io; could you please create a PR on your Github thus I can review patches from there.
>> Just let me know the PR # after you creating it.
>>
>> Thanks
>> Abner
>>
>>> -----Original Message-----
>>> From: Minh Nguyen<minhnguyen1 at amperemail.onmicrosoft.com>
>>> Sent: Friday, May 5, 2023 1:35 PM
>>> To: Chang, Abner<Abner.Chang at amd.com>; Minh Nguyen
>>> <minhnguyen1 at os.amperecomputing.com>;devel at edk2.groups.io
>>> Cc:patches at amperecomputing.com;nicklew at nvidia.com;igork at ami.com;
>>> nhi at os.amperecomputing.com;tinhnguyen at os.amperecomputing.com
>>> Subject: Re: [PATCH V3 0/5] Adding necessary changes for RedfishPkg
>>>
>>> Caution: This message originated from an External Source. Use proper
>>> caution when opening attachments, clicking links, or responding.
>>>
>>>
>>> Hi Abner,
>>>
>>>    Yes, me too. I have sent the email tomiki.demeter at intel.com  for checking
>>> it.
>>>
>>> Thanks,
>>>
>>> Minh Nguyen
>>>
>>> On 5/5/2023 12:03 PM, Chang, Abner wrote:
>>>> [AMD Official Use Only - General]
>>>>
>>>> Hi Minh,
>>>> I don't know why however I can't see V3 patch set on group.io. Can you see
>>> those patches on group.io?
>>>> Abner
>>>>
>>>>> -----Original Message-----
>>>>> From: Minh Nguyen<minhnguyen1 at os.amperecomputing.com>
>>>>> Sent: Friday, May 5, 2023 11:58 AM
>>>>> To:devel at edk2.groups.io
>>>>> Cc:patches at amperecomputing.com; Chang, Abner
>>> <Abner.Chang at amd.com>;
>>>>> nicklew at nvidia.com;igork at ami.com;nhi at os.amperecomputing.com;
>>>>> tinhnguyen at os.amperecomputing.com;
>>>>> Minh Nguyen<minhnguyen1 at os.amperecomputing.com>
>>>>> Subject: [PATCH V3 0/5] Adding necessary changes for RedfishPkg
>>>>>
>>>>> Caution: This message originated from an External Source. Use proper
>>>>> caution when opening attachments, clicking links, or responding.
>>>>>
>>>>>
>>>>> This patchset adds necessary changes for RedfishPkg to avoid some
>>>>> unexpected cases and fix compilation.
>>>>>
>>>>> Changes since v3:
>>>>>    + Replaced __FUNCTION__ with __func__ to be more C11 compliant.
>>>>> Changes since v2:
>>>>>    + Added "Cc:" to maintainers in commit message.
>>>>>    + Corrected patch format subject prefix.
>>>>> Changes since v1:
>>>>>    + Removed redundant change and change the commit message for more
>>>>> precise in PATCH 2/5.
>>>>>
>>>>> Nhi Pham (1):
>>>>>     RedfishPkg: Add missing newline character
>>>>>
>>>>> Vu Nguyen (4):
>>>>>     RedfishPkg: Correct variable type to prevent memory corruption
>>>>>     RedfishPkg: Fix condition checking of error status
>>>>>     RedfishPkg: Create RestEx child on selected interface
>>>>>     RedfishPkg: Fix compile issue on Linux
>>>>>
>>>>>    RedfishPkg/Include/Library/RestExLib.h                       |   3 +
>>>>>    RedfishPkg/Include/Pcd/RestExServiceDevicePath.h             |   5 +-
>>>>>    RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h            |   3 +-
>>>>>    RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c               | 153
>>> ++++++++----
>>>>> --------
>>>>>    RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c           |   4 +-
>>>>>    RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c |   3 +-
>>>>>    6 files changed, 73 insertions(+), 98 deletions(-)
>>>>>
>>>>> --
>>>>> 2.39.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104156): https://edk2.groups.io/g/devel/message/104156
Mute This Topic: https://groups.io/mt/98699661/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20230505/85d7f9f0/attachment.htm>