[edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt

[Michael D Kinney]

The issue I saw was a mix of / and \ in the file path.  On Windows $(DEBUG_DIR) would
Have '\' in path and then a '/' before $(MODULE_NAME).  Without the quotes, this
would generate an error.  With quotes, it would get the full filename correct.

On Linux, only '/' are used for the whole path and everything works with and
Without quotes.

Mike

> -----Original Message-----
> From: gaoliming <gaoliming at byosoft.com.cn>
> Sent: Friday, May 5, 2023 8:01 PM
> To: devel at edk2.groups.io; Kinney, Michael D <michael.d.kinney at intel.com>
> Cc: 'Rebecca Cran' <rebecca at bsdio.com>; Feng, Bob C
> <bob.c.feng at intel.com>; Chen, Christine <yuwei.chen at intel.com>
> Subject: 回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> ADDDEBUGFLAG in tools_def.txt
> 
> Mike:
>   Do you mean $(DEBUG_DIR)/$(MODULE_NAME).debug file path may have
> space on
> windows OS? Does the workspace directory include the space?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 Michael D
> > Kinney
> > 发送时间: 2023年5月6日 10:47
> > 收件人: devel at edk2.groups.io
> > 抄送: Rebecca Cran <rebecca at bsdio.com>; Liming Gao
> > <gaoliming at byosoft.com.cn>; Bob Feng <bob.c.feng at intel.com>; Yuwei
> Chen
> > <yuwei.chen at intel.com>
> > 主题: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> > ADDDEBUGFLAG in tools_def.txt
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4448
> >
> > Update tools_def.txt to add quotes around the file target in
> > OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool
> > chains used on Windows.
> >
> > Cc: Rebecca Cran <rebecca at bsdio.com>
> > Cc: Liming Gao <gaoliming at byosoft.com.cn>
> > Cc: Bob Feng <bob.c.feng at intel.com>
> > Cc: Yuwei Chen <yuwei.chen at intel.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney at intel.com>
> > ---
> >  BaseTools/Conf/tools_def.template | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/BaseTools/Conf/tools_def.template
> > b/BaseTools/Conf/tools_def.template
> > index 1b3a9e7a540a..535dda1d5d99 100755
> > --- a/BaseTools/Conf/tools_def.template
> > +++ b/BaseTools/Conf/tools_def.template
> > @@ -731,9 +731,9 @@ NOOPT_VS2019_AARCH64_DLINK_FLAGS   =
> > /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
> >  *_*_*_OBJCOPY_FLAGS             = objcopy not needed for
> >  *_*_*_SYMRENAME_PATH            = echo
> >  *_*_*_SYMRENAME_FLAGS           = Symbol renaming not needed for
> > -DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG     =
> > --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> > +DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG     =
> > --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> >  RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG   =
> > -NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG     =
> > --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> > +NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG     =
> > --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> >  *_*_*_OBJCOPY_STRIPFLAG            = --strip-unneeded -R .eh_frame
> >  *_*_*_DTC_FLAGS                    = -H epapr
> >  *_*_*_DTCPP_PATH                   = DEF(DTCPP_BIN)
> > --
> > 2.40.1.windows.1
> >
> >
> >
> > 
> >
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104181): https://edk2.groups.io/g/devel/message/104181
Mute This Topic: https://groups.io/mt/98720453/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3943202/1813853/130120423/xyzzy [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-