Re: 回复: [ ** SPAMMAIL ** ][edk2-devel] [PATCH v3 3/3] MdePkg/IndustryStandard: Add Interface Capabilities definitions

[Tinh Nguyen via groups.io]

Hi Liming,

Sorry I missed your comment. I have submitted v4 and here is the pull 
request

https://github.com/tianocore/edk2/pull/4352

Thanks,

Tinh

On 04/05/2023 15:06, gaoliming wrote:
> Tinh:
>    For the patch subject, I suggest to add IPMI key word to specify this change is for IPMI, such as MdePkg/IndustryStandard: Add IPMI Interface Capabilities definitions
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 Tinh Nguyen
>> via groups.io
>> 发送时间: 2023年5月3日 19:24
>> 收件人: devel at edk2.groups.io
>> 抄送: patches at amperecomputing.com; michael.d.kinney at intel.com;
>> gaoliming at byosoft.com.cn; zhiguang.liu at intel.com; abner.chang at amd.com;
>> Tinh Nguyen <tinhnguyen at os.amperecomputing.com>
>> 主题: [ ** SPAMMAIL ** ][edk2-devel] [PATCH v3 3/3]
>> MdePkg/IndustryStandard: Add Interface Capabilities definitions
>>
>> This adds more definitions for the IPMI Get System Interface
>> Capabilities command.
>>
>> Signed-off-by: Tinh Nguyen <tinhnguyen at os.amperecomputing.com>
>> Cc: Michael D Kinney <michael.d.kinney at intel.com>
>> Cc: Liming Gao <gaoliming at byosoft.com.cn>
>> Cc: Zhiguang Liu <zhiguang.liu at intel.com>
>> Cc: Abner Chang <abner.chang at amd.com>
>> Reviewed-by: Abner Chang <abner.chang at amd.com>
>> ---
>>   MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46
>> ++++++++++++++++++++
>>   1 file changed, 46 insertions(+)
>>
>> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
>> b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
>> index a5835ba08c00..b6bc91f46c2d 100644
>> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
>> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
>> @@ -13,6 +13,7 @@
>>
>>     Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.<BR>
>>     Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
>> +  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
>>     SPDX-License-Identifier: BSD-2-Clause-Patent
>>   **/
>>
>> @@ -1046,6 +1047,51 @@ typedef struct {
>>   //  Constants and Structure definitions for "Get System Interface
>> Capabilities" command to follow here
>>   //
>>
>> +#define
>> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SSIF  0x0
>> +#define
>> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_KCS   0x1
>> +#define
>> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SMIC  0x2
>> +
>> +typedef union {
>> +  struct {
>> +    UINT8    InterfaceType : 4;
>> +    UINT8    Reserved      : 4;
>> +  } Bits;
>> +  UINT8    Uint8;
>> +} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST;
>> +
>> +typedef union {
>> +  struct {
>> +    UINT8    Version            : 3;
>> +    UINT8    PecSupport         : 1;
>> +    UINT8    Reserved           : 2;
>> +    UINT8    TransactionSupport : 2;
>> +  } Bits;
>> +  UINT8    Uint8;
>> +} IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES;
>> +
>> +typedef union {
>> +  struct {
>> +    UINT8    SystemInterfaceVersion : 3;
>> +    UINT8    Reserved               : 5;
>> +  } Bits;
>> +  UINT8    Uint8;
>> +} IPMI_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES;
>> +
>> +typedef struct {
>> +  UINT8                                      CompletionCode;
>> +  UINT8                                      Reserved;
>> +  IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES    InterfaceCap;
>> +  UINT8                                      InputMsgSize;
>> +  UINT8                                      OutputMsgSize;
>> +} IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE;
>> +
>> +typedef struct {
>> +  UINT8
>> CompletionCode;
>> +  UINT8                                          Reserved;
>> +  IPMI_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES    InterfaceCap;
>> +  UINT8
>> InputMaxMsgSize;
>> +} IPMI_GET_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES_RESPONSE;
>> +
>>   //
>>   //  Definitions for Get System Interface Capabilities command SSIF
>> transaction support
>>   //
>> --
>> 2.40.0
>>
>>
>>
>> 
>>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104219): https://edk2.groups.io/g/devel/message/104219
Mute This Topic: https://groups.io/mt/98679751/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-