[edk2-devel] [PATCH 0/2] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one

Pedro Falcato pedro.falcato at gmail.com
Mon May 8 21:52:44 UTC 2023


This patch-set replaces the OVMF specific SataControllerDxe with the MdeModulePkg/Bus/Pci one.
They were both forked from the same code, and are code-and-functionality similar. As such, there
seems to be no need for duplication here.

First I manually replayed OvmfPkg/SataControllerDxe's patches on top of the generic one. Only one
seemed to make sense. The second patch removes OvmfPkg/SataControllerDxe and replaces it for all platforms
under OvmfPkg. 

Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)).
More testing from other, alternative platforms is desired, although breakage seems unlikely.

(+CC Laszlo as the author of the original SataControllerDxe patches)

Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
Cc: Jiewen Yao <jiewen.yao at intel.com>
Cc :Jordan Justen <jordan.l.justen at intel.com>
Cc: Gerd Hoffmann <kraxel at redhat.com>
Cc: Erdem Aktas <erdemaktas at google.com>
Cc: James Bottomley <jejb at linux.ibm.com>
Cc: Min Xu <min.m.xu at intel.com>
Cc: Tom Lendacky <thomas.lendacky at amd.com>
Cc: Michael Roth <michael.roth at amd.com>
Cc: Rebecca Cran <rebecca at bsdio.com>
Cc: Peter Grehan <grehan at freebsd.org>
Cc: Corvin Köhne <corvink at freebsd.org>
Cc: Sebastien Boeuf <sebastien.boeuf at intel.com>
Cc: Anthony Perard <anthony.perard at citrix.com>
Cc: Julien Grall <julien at xen.org>
Cc: Laszlo Ersek <lersek at redhat.com>

Pedro Falcato (2):
  MdeModulePkg/SataControllerDxe: Remove useless null check
  OvmfPkg: Replace the OVMF-specific SataControllerDxe with a generic
    one

 .../Pci/SataControllerDxe/SataController.c    |   44 +-
 OvmfPkg/AmdSev/AmdSevX64.dsc                  |    2 +-
 OvmfPkg/AmdSev/AmdSevX64.fdf                  |    2 +-
 OvmfPkg/Bhyve/BhyveX64.dsc                    |    2 +-
 OvmfPkg/Bhyve/BhyveX64.fdf                    |    2 +-
 OvmfPkg/CloudHv/CloudHvX64.dsc                |    2 +-
 OvmfPkg/CloudHv/CloudHvX64.fdf                |    2 +-
 OvmfPkg/IntelTdx/IntelTdxX64.dsc              |    2 +-
 OvmfPkg/IntelTdx/IntelTdxX64.fdf              |    2 +-
 OvmfPkg/Microvm/MicrovmX64.dsc                |    2 +-
 OvmfPkg/Microvm/MicrovmX64.fdf                |    2 +-
 OvmfPkg/OvmfPkgIa32.dsc                       |    2 +-
 OvmfPkg/OvmfPkgIa32.fdf                       |    2 +-
 OvmfPkg/OvmfPkgIa32X64.dsc                    |    2 +-
 OvmfPkg/OvmfPkgIa32X64.fdf                    |    2 +-
 OvmfPkg/OvmfPkgX64.dsc                        |    2 +-
 OvmfPkg/OvmfPkgX64.fdf                        |    2 +-
 OvmfPkg/OvmfXen.dsc                           |    2 +-
 OvmfPkg/OvmfXen.fdf                           |    2 +-
 OvmfPkg/SataControllerDxe/ComponentName.c     |  170 ---
 OvmfPkg/SataControllerDxe/SataController.c    | 1112 -----------------
 OvmfPkg/SataControllerDxe/SataController.h    |  544 --------
 .../SataControllerDxe/SataControllerDxe.inf   |   43 -
 23 files changed, 39 insertions(+), 1910 deletions(-)
 delete mode 100644 OvmfPkg/SataControllerDxe/ComponentName.c
 delete mode 100644 OvmfPkg/SataControllerDxe/SataController.c
 delete mode 100644 OvmfPkg/SataControllerDxe/SataController.h
 delete mode 100644 OvmfPkg/SataControllerDxe/SataControllerDxe.inf

-- 
2.40.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104294): https://edk2.groups.io/g/devel/message/104294
Mute This Topic: https://groups.io/mt/98771779/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list