[edk2-devel] [PATCH v3 1/1] Platform/SbsaQemu: read platform version

[Marcin Juszkiewicz]

W dniu 10.05.2023 o 18:14, Rebecca Cran pisze:

> Sorry, but there are new problems.

No problem. Thanks for reviewing.

> There should be a space before the parenthesis in the 'DEBUG' line.

No problem. I hope that one day someone will run source formatter on 
whole edk2-platforms so it would be possible to autoformat changes 
before posting.

> PcdGet32 doesn't return a RETURN_STATUS or EFI_STATUS, so 
> ASSERT_EFI_ERROR is incorrect.

fixed




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104598): https://edk2.groups.io/g/devel/message/104598
Mute This Topic: https://groups.io/mt/98809146/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-