回复: [edk2-devel] [PATCH v9 0/5] Trace Hub debug library support
gaoliming via groups.io
gaoliming=byosoft.com.cn at groups.io
Thu May 11 02:00:53 UTC 2023
Acked-by: Liming Gao <gaoliming at byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 Guo, Gua
> 发送时间: 2023年5月11日 7:39
> 收件人: devel at edk2.groups.io
> 抄送: gua.guo at intel.com
> 主题: [edk2-devel] [PATCH v9 0/5] Trace Hub debug library support
>
> From: Gua Guo <gua.guo at intel.com>
>
> V9: Add more maintainers into CC list
> - https://github.com/tianocore/edk2/pull/3901
> F: *
> M: Andrew Fish <afish at apple.com> [ajfish]
> M: Leif Lindholm <quic_llindhol at quicinc.com> [leiflindholm]
> M: Michael D Kinney <michael.d.kinney at intel.com> [mdkinney]
>
> MdeModulePkg
> M: Jian J Wang <jian.j.wang at intel.com> [jwang36]
> M: Liming Gao <gaoliming at byosoft.com.cn> [lgao4]
>
> .pytool/
> M: Sean Brogan <sean.brogan at microsoft.com> [spbrogan]
> M: Michael Kubacki <mikuback at linux.microsoft.com> [makubacki]
> R: Michael D Kinney <michael.d.kinney at intel.com> [mdkinney]
> R: Liming Gao <gaoliming at byosoft.com.cn> [lgao4]
>
> MdePkg/
> M: Michael D Kinney <michael.d.kinney at intel.com> [mdkinney]
> M: Liming Gao <gaoliming at byosoft.com.cn> [lgao4]
> R: Zhiguang Liu <zhiguang.liu at intel.com> [LiuZhiguang001]
>
>
> V8: Add MdeModulePkg maintainers into CC list
>
> V7: Miss one patch on V6
>
> V6:
> - https://github.com/tianocore/edk2/pull/3901
> Split submodule into new patch
> Fix formatting issue
> Add Review-by message
> Offline check with Victor to use my sign-off name.
>
> V5: if no other open, it will be final change
> - https://github.com/tianocore/edk2/pull/3901
> Fix random exception when long run catalog debug message
>
> V4
> - https://github.com/tianocore/edk2/pull/3901 - Done
> Enhance SwapBytesGuid to use CopyGuid instead of CopyMem, to make
> implement code more simple.
>
> V3
> - https://github.com/tianocore/edk2/pull/3901 - Done
> - Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why
> MAX_TRACE_HUB_DEBUG_INSTANCE hardcoded to 5?
> Solution: Remove this macro, use Library Constructor to allocate it
> dynamiclly.
> - Open:
> MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommo
> n.c: SwapBytesGuid () algorithm wrong.
> Solution: Follow correct algorithm to implement it.
> VOID
> EFIAPI
> SwapBytesGuid (
> IN GUID *Guid, <----------- In PreMem, guid is global
> data so region is readonly, add output data to support it.
> OUT GUID *ConvertedGuid
> );
>
> - Open: Merge MSFT and GCC CC_FLAGS as they both supports -D
> Solution: use *_*_*_CC_FLAGS = -DMIPI_SYST_STATIC to unified both.
>
>
> V2
> - https://github.com/tianocore/edk2/pull/3901
> - Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why
> MAX_TRACE_HUB_DEBUG_INSTANCE hardcoded to 5?
> - Open:
> MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommo
> n.c: SwapBytesGuid () algorithm wrong.
> - Open: Merge MSFT and GCC CC_FLAGS as they both supports -D
>
> V1
> Previous PR:
> - https://github.com/tianocore/edk2/pull/3613
> - TraceHubDebugLib without submodule - Reject
>
> - https://github.com/tianocore/edk2/pull/3793
> - TraceHubDebugLib with submodule and without seperate into
> MipiSysTLib and TraceHubDebugLib - Reject
>
> Gua Guo (5):
> MdePkg: Add mipisyst submodule
> MdePkg: Add MipiSysTLib library
> MdePkg: Add NULL library of TraceHubDebugSysTLib
> MdeModulePkg: Add TraceHubDebugSysTLib library
> Maintainers.txt: Update reviewers and maintainers for
> TraceHubDebugLib.
>
> .gitmodules | 3 +
> .pytool/CISettings.py | 2 +
> Maintainers.txt | 18 +
> .../Include/Guid/TraceHubDebugInfoHob.h | 24 +
> .../BaseTraceHubDebugSysTLib.c | 245 ++++++
> .../BaseTraceHubDebugSysTLib.inf | 44 +
> .../DxeSmmTraceHubDebugSysTLib.c | 263 ++++++
> .../DxeSmmTraceHubDebugSysTLib.inf | 51 ++
> .../InternalTraceHubApi.c | 74 ++
> .../InternalTraceHubApi.h | 37 +
> .../InternalTraceHubApiCommon.c | 200 +++++
> .../InternalTraceHubApiCommon.h | 119 +++
> .../PeiTraceHubDebugSysTLib.c | 282 +++++++
> .../PeiTraceHubDebugSysTLib.inf | 50 ++
> .../Library/TraceHubDebugSysTLib/Readme.md | 26 +
> MdeModulePkg/MdeModulePkg.dec | 21 +
> MdeModulePkg/MdeModulePkg.dsc | 3 +
> MdeModulePkg/MdeModulePkg.uni | 18 +
> MdePkg/Include/Library/MipiSysTLib.h | 66 ++
> MdePkg/Include/Library/TraceHubDebugSysTLib.h | 81 ++
> MdePkg/Library/MipiSysTLib/GenMipiSystH.py | 132 +++
> MdePkg/Library/MipiSysTLib/MipiSysTLib.c | 123 +++
> MdePkg/Library/MipiSysTLib/MipiSysTLib.inf | 52 ++
> MdePkg/Library/MipiSysTLib/Platform.c | 164 ++++
> MdePkg/Library/MipiSysTLib/Platform.h | 138 +++
> MdePkg/Library/MipiSysTLib/Readme.md | 25 +
> MdePkg/Library/MipiSysTLib/mipi_syst.h | 789
> ++++++++++++++++++
> MdePkg/Library/MipiSysTLib/mipisyst | 1 +
> .../TraceHubDebugSysTLibNull.c | 76 ++
> .../TraceHubDebugSysTLibNull.inf | 29 +
> MdePkg/MdePkg.ci.yaml | 12 +-
> MdePkg/MdePkg.dec | 9 +
> MdePkg/MdePkg.dsc | 2 +
> ReadMe.rst | 1 +
> 34 files changed, 3177 insertions(+), 3 deletions(-)
> create mode 100644
> MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h
> create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.
> c
> create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.
> inf
> create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSys
> TLib.c
> create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSys
> TLib.inf
> create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.c
> create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.h
> create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommo
> n.c
> create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommo
> n.h
> create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.c
> create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.in
> f
> create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/Readme.md
> create mode 100644 MdePkg/Include/Library/MipiSysTLib.h
> create mode 100644 MdePkg/Include/Library/TraceHubDebugSysTLib.h
> create mode 100644 MdePkg/Library/MipiSysTLib/GenMipiSystH.py
> create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.c
> create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.inf
> create mode 100644 MdePkg/Library/MipiSysTLib/Platform.c
> create mode 100644 MdePkg/Library/MipiSysTLib/Platform.h
> create mode 100644 MdePkg/Library/MipiSysTLib/Readme.md
> create mode 100644 MdePkg/Library/MipiSysTLib/mipi_syst.h
> create mode 160000 MdePkg/Library/MipiSysTLib/mipisyst
> create mode 100644
> MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.c
> create mode 100644
> MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.inf
>
> --
> 2.39.2.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104653): https://edk2.groups.io/g/devel/message/104653
Mute This Topic: https://groups.io/mt/98819743/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list