Re: [edk2-devel] 回复: [PATCH v4 0/3] Add IPMI SSIF definitions

[Tinh Nguyen via groups.io]

Hi Liming,

If there are no concerns, can you assist in merging them?

Thanks

- Tinh

On 08/05/2023 08:07, gaoliming wrote:
> Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn>
>
>> -----邮件原件-----
>> 发件人: Tinh Nguyen <tinhnguyen at os.amperecomputing.com>
>> 发送时间: 2023年5月7日 17:29
>> 收件人: devel at edk2.groups.io
>> 抄送: patches at amperecomputing.com; michael.d.kinney at intel.com;
>> gaoliming at byosoft.com.cn; zhiguang.liu at intel.com; abner.chang at amd.com;
>> Tinh Nguyen <tinhnguyen at os.amperecomputing.com>
>> 主题: [PATCH v4 0/3] Add IPMI SSIF definitions
>>
>> Change from v3:
>>    - Add IPMI key word to commit subject
>>
>> Change from v2:
>>    - Add the carbon copy (Cc) in the commit message.
>>    - Add Bugzilla ID in the commit message.
>>    - Mention why I set the number of retries as 250.
>>
>> Change from v1:
>>    - Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs
>>    - Correct some indent and comment style.
>>    - Change the PCDs name for a more readable.
>>    - Support KCS/SMIC Interface Capabilities too.
>>
>> Tinh Nguyen (3):
>>    MdePkg/IndustryStandard: Add definitions for IPMI SSIF
>>    MdePkg: Add new PCDs for IPMI SSIF
>>    MdePkg/IndustryStandard: Add IPMI Interface Capabilities definitions
>>
>>   MdePkg/MdePkg.dec                              | 27 ++++++
>>   MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 +++++++++
>>   MdePkg/Include/IndustryStandard/IpmiSsif.h     | 98
>> ++++++++++++++++++++
>>   3 files changed, 171 insertions(+)
>>   create mode 100644 MdePkg/Include/IndustryStandard/IpmiSsif.h
>>
>> --
>> 2.40.0
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104781): https://edk2.groups.io/g/devel/message/104781
Mute This Topic: https://groups.io/mt/98752949/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-