[edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib
Attar, AbdulLateef (Abdul Lateef) via groups.io
AbdulLateef.Attar=amd.com at groups.io
Fri May 12 06:08:02 UTC 2023
[AMD Official Use Only - General]
Hi Ray,
Looks like some issue with my mailbox, I saw your mail after submitting patch V12.
I'll rework and send V13 patch series.
Thanks
AbduL
-----Original Message-----
From: Ni, Ray <ray.ni at intel.com>
Sent: 12 May 2023 09:11
To: devel at edk2.groups.io; Ni, Ray <ray.ni at intel.com>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar at amd.com>; Wu, Jiaxin <jiaxin.wu at intel.com>
Cc: Grimes, Paul <Paul.Grimes at amd.com>; Chang, Abner <Abner.Chang at amd.com>; Dong, Eric <eric.dong at intel.com>; Kumar, Rahul R <rahul.r.kumar at intel.com>; Gerd Hoffmann <kraxel at redhat.com>; Kinney, Michael D <michael.d.kinney at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu at intel.com>; Ard Biesheuvel <ardb+tianocore at kernel.org>; Yao, Jiewen <jiewen.yao at intel.com>; Justen, Jordan L <jordan.l.justen at intel.com>; Holthaus, CJ <cj.holthaus at intel.com>
Subject: RE: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
Abdul,
I checked your V12 patch. It seems none of comments I have for your V11 are not addressed. (check my inline reply below)
Can we get aligned firstly then you send out next version patches?
This could also save my time on downloading your changes and reviewing them one by one.
Thanks,
Ray
> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Ni, Ray
> Sent: Thursday, May 11, 2023 2:56 PM
> To: Abdul Lateef Attar <abdattar at amd.com>; devel at edk2.groups.io; Wu,
> Jiaxin <jiaxin.wu at intel.com>
> Cc: Paul Grimes <paul.grimes at amd.com>; Abner Chang
> <abner.chang at amd.com>; Dong, Eric <eric.dong at intel.com>; Kumar, Rahul
> R <rahul.r.kumar at intel.com>; Gerd Hoffmann <kraxel at redhat.com>;
> Kinney, Michael D <michael.d.kinney at intel.com>; Gao, Liming
> <gaoliming at byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu at intel.com>;
> Ard Biesheuvel <ardb+tianocore at kernel.org>; Yao, Jiewen
> <jiewen.yao at intel.com>; Justen, Jordan L <jordan.l.justen at intel.com>;
> Holthaus, CJ <cj.holthaus at intel.com>
> Subject: Re: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib
> and MmSaveStateLib
>
> > UefiCpuPkg: Adds MmSaveStateLib library class
> You can take "Reviewed-by: Ray Ni <ray.ni at intel.com>" for this patch.
>
> > UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code
> You can take "Reviewed-by: Ray Ni <ray.ni at intel.com>" for this patch.
>
> > UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family
> One comment: can you please change the BASE_NAME in lib INF to
> "AmdSmmCpuFeaturesLib"?
> The BASE_NAME guides tool to generate the .Lib file in the disk.
> Choosing different BASE_NAME for Intel and AMD lib instance can avoid
> one LIB file is replaced by the other during pkg build.
>
> > UefiCpuPkg: Implements MmSaveStateLib for Intel
> 1. MmSaveStateLib local functions should not have "EFIAPI". Please
> only add "EFIAPI" for lib APIs.
1. not addressed in V12.
> 2. MmSaveStateGetRegisterLma() doesn't need to carry "CpuIndex" as
> parameter. Can you please remove the parameter?
2. not addressed in V12.
> 3. MmSaveStateGetRegisterIndex () returns wrong value for Intel
> processors because it uses Offset ( = 2) but Intel implementation uses Offset ( = 4).
>
> (I remember comments #1, #3 were both raised last time when I reviewed
> the
> patch.)
3. not addressed in V12.
>
> > UefiCpuPkg: Removes SmmCpuFeaturesReadSaveStateRegister
> You can take "Reviewed-by: Ray Ni <ray.ni at intel.com>" for this patch.
>
>
> One more comment:
> Can you please avoid FILE_GUID overridden in UefiCpuPkg.dsc for Intel
> instance of SmmCpu driver?
> AMD instance can override the FILE_GUID for sure.
4. not addressed in V12.
>
> @Wu, Jiaxin, we will need to change the close-source SmmCpuFeatureLib
> accordingly (separating the SaveState access code into a different
> lib) when this patch series are merged.
>
> > -----Original Message-----
> > From: Abdul Lateef Attar <abdattar at amd.com>
> > Sent: Saturday, May 6, 2023 12:07 PM
> > To: devel at edk2.groups.io
> > Cc: Abdul Lateef Attar <abdattar at amd.com>; Paul Grimes
> > <paul.grimes at amd.com>; Abner Chang <abner.chang at amd.com>; Dong, Eric
> > <eric.dong at intel.com>; Ni, Ray <ray.ni at intel.com>; Kumar, Rahul R
> > <rahul.r.kumar at intel.com>; Gerd Hoffmann <kraxel at redhat.com>;
> > Kinney, Michael D <michael.d.kinney at intel.com>; Gao, Liming
> > <gaoliming at byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu at intel.com>;
> > Ard Biesheuvel <ardb+tianocore at kernel.org>; Yao, Jiewen
> <jiewen.yao at intel.com>;
> > Justen, Jordan L <jordan.l.justen at intel.com>
> > Subject: [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and
> > MmSaveStateLib
> >
> > PR: https://github.com/tianocore/edk2/pull/4341
> >
> > V11: Delta changes
> > Drop the OVMF implementation of MmSaveStateLib
> > V10: Delta changes:
> > Addressed review comments from Abner.
> > V9: Delta changes:
> > Addressed review comments.
> > Rename to MmSaveStateLib.
> > Also rename SMM_ defines to MM_.
> > Implemented OVMF MmSaveStateLib.
> > Removes SmmCpuFeaturesReadSaveStateRegister and
> > SmmCpuFeaturesWriteSaveStateRegister
> > function interface.
> > V8 delta changes:
> > Addressed review comments from Abner,
> > Fix the whitespace error.
> > Seperate the Ovmf changes to another patch
> > V7 delta changes:
> > Adds SmmSmramSaveStateLib for Intel processor.
> > Integrate SmmSmramSaveStateLib library.
> > V6 delta changes:
> > Addressed review comments for Ray NI.
> > removed unnecessary EFIAPI.
> > V5 delta changes:
> > rebase to master branch.
> > updated Reviewed-by
> > V4 delta changes:
> > rebase to master branch.
> > added reviewed-by.
> > V3 delta changes:
> > Addressed review comments from Abner chang.
> > Re-arranged patch order.
> >
> > Cc: Paul Grimes <paul.grimes at amd.com>
> > Cc: Abner Chang <abner.chang at amd.com>
> > Cc: Eric Dong <eric.dong at intel.com>
> > Cc: Ray Ni <ray.ni at intel.com>
> > Cc: Rahul Kumar <rahul1.kumar at intel.com>
> > Cc: Gerd Hoffmann <kraxel at redhat.com>
> > Cc: Michael D Kinney <michael.d.kinney at intel.com>
> > Cc: Liming Gao <gaoliming at byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu at intel.com>
> > Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> > Cc: Jiewen Yao <jiewen.yao at intel.com>
> > Cc: Jordan Justen <jordan.l.justen at intel.com>
> > Cc: Abdul Lateef Attar <abdattar at amd.com>
> >
> > Abdul Lateef Attar (8):
> > MdePkg: Adds AMD SMRAM save state map
> > UefiCpuPkg: Adds MmSaveStateLib library class
> > UefiCpuPkg: Implements MmSaveStateLib library instance
> > UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code
> > UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family
> > UefiCpuPkg: Implements MmSaveStateLib for Intel
> > UefiCpuPkg: Removes SmmCpuFeaturesReadSaveStateRegister
> > OvmfPkg: Uses MmSaveStateLib library
> >
> > UefiCpuPkg/UefiCpuPkg.dec | 4 +
> > OvmfPkg/OvmfPkgIa32.dsc | 1 +
> > OvmfPkg/OvmfPkgIa32X64.dsc | 3 +
> > OvmfPkg/OvmfPkgX64.dsc | 1 +
> > UefiCpuPkg/UefiCpuPkg.dsc | 14 +
> > .../MmSaveStateLib/AmdMmSaveStateLib.inf | 28 +
> > .../MmSaveStateLib/IntelMmSaveStateLib.inf | 28 +
> > .../AmdSmmCpuFeaturesLib.inf | 38 +
> > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 +
> > .../Include/Register/Amd/SmramSaveStateMap.h | 194 +++++
> > UefiCpuPkg/Include/Library/MmSaveStateLib.h | 70 ++
> > .../Include/Library/SmmCpuFeaturesLib.h | 52 --
> > .../Library/MmSaveStateLib/MmSaveState.h | 102 +++
> > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 56 +-
> > .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 767 ------------------
> > .../Library/MmSaveStateLib/AmdMmSaveState.c | 309 +++++++
> > .../Library/MmSaveStateLib/IntelMmSaveState.c | 413 ++++++++++
> > .../MmSaveStateLib/MmSaveStateCommon.c | 138 ++++
> > .../SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c | 387 +++++++++
> > .../IntelSmmCpuFeaturesLib.c | 70 ++
> > .../SmmCpuFeaturesLibCommon.c | 128 ---
> > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 11 +-
> > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 500 +-----------
> > MdePkg/MdePkg.ci.yaml | 4 +-
> > 24 files changed, 1812 insertions(+), 1508 deletions(-) create
> > mode 100644 UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf
> > create mode 100644
> > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveStateLib.inf
> > create mode 100644
> > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.inf
> > create mode 100644 MdePkg/Include/Register/Amd/SmramSaveStateMap.h
> > create mode 100644 UefiCpuPkg/Include/Library/MmSaveStateLib.h
> > create mode 100644 UefiCpuPkg/Library/MmSaveStateLib/MmSaveState.h
> > create mode 100644
> UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c
> > create mode 100644
> UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveState.c
> > create mode 100644
> > UefiCpuPkg/Library/MmSaveStateLib/MmSaveStateCommon.c
> > create mode 100644
> > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c
> >
> > --
> > 2.25.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104806): https://edk2.groups.io/g/devel/message/104806
Mute This Topic: https://groups.io/mt/98720163/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list