[edk2-devel] [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled build

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu at intel.com>

Thanks,
Chasel



> -----Original Message-----
> From: Ni, Ray <ray.ni at intel.com>
> Sent: Wednesday, May 24, 2023 5:29 AM
> To: devel at edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>; Oram, Isaac W <isaac.w.oram at intel.com>;
> Gao, Liming <gaoliming at byosoft.com.cn>; Dong, Eric <eric.dong at intel.com>
> Subject: [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled
> build
> 
> build_bios.py supports caller to pass in "--performance" flag but the script
> implemnetation just ignores this flag.
> 
> The patch adds the missing logic to invoke build.py with "--pcd
> gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable=True"
> when "--performance" is supplied.
> 
> Signed-off-by: Ray Ni <ray.ni at intel.com>
> Cc: Chasel Chiu <chasel.chiu at intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> Cc: Isaac Oram <isaac.w.oram at intel.com>
> Cc: Liming Gao <gaoliming at byosoft.com.cn>
> Cc: Eric Dong <eric.dong at intel.com>
> ---
>  Platform/Intel/build_bios.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index
> da4097d5db..9c95cfff76 100755
> --- a/Platform/Intel/build_bios.py
> +++ b/Platform/Intel/build_bios.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python3
> +#!/usr/bin/env python3 # # @ build_bios.py # Builds BIOS using configuration
> files and dynamically@@ -421,6 +421,10 @@ def build(config):
>          command.append("--pcd")
> command.append("gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection=1
> ") +    if config.get("PERFORMANCE_BUILD", "FALSE") == "TRUE":+
> command.append("--pcd")+
> command.append("gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable=T
> rue")+     shell = True     if os.name == "posix":         shell = False--
> 2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105286): https://edk2.groups.io/g/devel/message/105286
Mute This Topic: https://groups.io/mt/99107260/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-