[edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: Use DEBUG_MANAGEABILITY

Nickle Wang via groups.io nicklew=nvidia.com at groups.io
Wed May 31 12:39:24 UTC 2023


Reviewed-by: Nickle Wang <nicklew at nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: abner.chang at amd.com <abner.chang at amd.com>
> Sent: Tuesday, May 30, 2023 3:42 PM
> To: devel at edk2.groups.io
> Cc: Nickle Wang <nicklew at nvidia.com>; Igor Kulchytskyy <igork at ami.com>
> Subject: [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: Use
> DEBUG_MANAGEABILITY
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Abner Chang <abner.chang at amd.com>
> 
> Use debug print level DEBUG_MANAGEABILITY in
> RedfishClientPkg.
> 
> Signed-off-by: Abner Chang <abner.chang at amd.com>
> Cc: Nickle Wang <nicklew at nvidia.com>
> Cc: Igor Kulchytskyy <igork at ami.com>
> ---
>  RedfishClientPkg/Include/RedfishBase.h        |  2 +-
>  .../Features/Bios/v1_0_9/Common/BiosCommon.c  | 10 ++++----
>  .../Features/Bios/v1_0_9/Dxe/BiosDxe.c        |  2 +-
>  .../v1_5_0/Common/ComputerSystemCommon.c      |  8 +++----
>  .../v1_5_0/Dxe/ComputerSystemDxe.c            |  2 +-
>  .../ComputerSystemCollectionDxe.c             |  2 +-
>  .../Memory/V1_7_1/Common/MemoryCommon.c       |  8 +++----
>  .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c    |  2 +-
>  .../MemoryCollectionDxe/MemoryCollectionDxe.c |  2 +-
>  .../EdkIIRedfishResourceConfigLib.c           |  2 +-
>  .../RedfishFeatureUtilityLib.c                | 24 +++++++++----------
>  .../PrivateLibrary/RedfishLib/RedfishLib.c    |  8 +++----
>  .../RedfishLib/edk2libredfish/src/service.c   | 18 +++++++-------
>  .../RedfishConfigLangMapDxe.c                 |  8 +++----
>  .../RedfishETagDxe/RedfishETagDxe.c           |  8 +++----
>  15 files changed, 53 insertions(+), 53 deletions(-)
> 
> diff --git a/RedfishClientPkg/Include/RedfishBase.h
> b/RedfishClientPkg/Include/RedfishBase.h
> index 1abe9517ef..d58d7579ce 100644
> --- a/RedfishClientPkg/Include/RedfishBase.h
> +++ b/RedfishClientPkg/Include/RedfishBase.h
> @@ -11,7 +11,7 @@
>  #define EFI_REDFISH_BASE_H_
> 
>  #define IS_EMPTY_STRING(a)  ((a) == NULL || (a)[0] == '\0')
> -#define REDFISH_DEBUG_TRACE  DEBUG_INFO
> +#define REDFISH_DEBUG_TRACE  DEBUG_MANAGEABILITY
> 
>  ///
>  /// This GUID is used for an EFI Variable that stores the Redfish data.
> diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> index 82a3d46548..8442608813 100644
> --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> @@ -65,7 +65,7 @@ RedfishConsumeResourceCommon (
>      //
>      // No change
>      //
> -    DEBUG ((DEBUG_INFO, "%a, ETAG: %s has no change, ignore consume
> action\n", __func__, Private->Uri));
> +    DEBUG ((DEBUG_MANAGEABILITY, "%a, ETAG: %s has no change, ignore
> consume action\n", __func__, Private->Uri));
>      Status = EFI_ALREADY_STARTED;
>      goto ON_RELEASE;
>    }
> @@ -352,7 +352,7 @@ ProvisioningBiosResources (
>    EdkIIRedfishResourceSetConfigureLang (&UnifiedConfigureLangList);
> 
>    for (Index = 0; Index < UnifiedConfigureLangList.Count; Index++) {
> -    DEBUG ((DEBUG_INFO, "[%d] create Bios resource from: %s\n",
> UnifiedConfigureLangList.List[Index].Index,
> UnifiedConfigureLangList.List[Index].ConfigureLang));
> +    DEBUG ((DEBUG_MANAGEABILITY, "[%d] create Bios resource from: %s\n",
> UnifiedConfigureLangList.List[Index].Index,
> UnifiedConfigureLangList.List[Index].ConfigureLang));
>      ProvisioningBiosResource (Private, UnifiedConfigureLangList.List[Index].Index,
> UnifiedConfigureLangList.List[Index].ConfigureLang);
>      FreePool (UnifiedConfigureLangList.List[Index].ConfigureLang);
>    }
> @@ -498,9 +498,9 @@ RedfishCheckResourceCommon (
>        continue;
>      }
> 
> -    DEBUG ((DEBUG_INFO, "%a, [%d] check attribute for: %s\n", __func__, Index,
> Property));
> +    DEBUG ((DEBUG_MANAGEABILITY, "%a, [%d] check attribute for: %s\n",
> __func__, Index, Property));
>      if (!MatchPropertyWithJsonContext (Property, Json)) {
> -      DEBUG ((DEBUG_INFO, "%a, property is missing: %s\n", __func__, Property));
> +      DEBUG ((DEBUG_MANAGEABILITY, "%a, property is missing: %s\n",
> __func__, Property));
>        Status = EFI_NOT_FOUND;
>      }
>    }
> @@ -692,7 +692,7 @@ HandleResource (
>      Status = EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Private-
> >InformationExchange);
>      if (EFI_ERROR (Status)) {
>        if (Status == EFI_UNSUPPORTED) {
> -        DEBUG ((DEBUG_INFO, "%a, \"%s\" is not handled by us\n", __func__, Uri));
> +        DEBUG ((DEBUG_MANAGEABILITY, "%a, \"%s\" is not handled by us\n",
> __func__, Uri));
>          return EFI_SUCCESS;
>        }
> 
> diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> index bbfbe7a873..623a9af8f6 100644
> --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> @@ -46,7 +46,7 @@ RedfishResourceProvisioningResource (
>      return EFI_INVALID_PARAMETER;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "%a, provisioning in %s mode\n", __func__,
> (PostMode ? L"POST" : L"PATCH")));
> +  DEBUG ((DEBUG_MANAGEABILITY, "%a, provisioning in %s mode\n", __func__,
> (PostMode ? L"POST" : L"PATCH")));
> 
>    Private =
> REDFISH_RESOURCE_COMMON_PRIVATE_DATA_FROM_RESOURCE_PROTOCOL
> (This);
> 
> diff --git
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste
> mCommon.c
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste
> mCommon.c
> index 168d62e3d7..7ed1bd55ea 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste
> mCommon.c
> +++
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste
> mCommon.c
> @@ -64,7 +64,7 @@ RedfishConsumeResourceCommon (
>      //
>      // No change
>      //
> -    DEBUG ((DEBUG_INFO, "%a, ETAG: %s has no change, ignore consume
> action\n", __func__, Private->Uri));
> +    DEBUG ((DEBUG_MANAGEABILITY, "%a, ETAG: %s has no change, ignore
> consume action\n", __func__, Private->Uri));
>      Status = EFI_ALREADY_STARTED;
>      goto ON_RELEASE;
>    }
> @@ -1324,7 +1324,7 @@ ProvisioningComputerSystemResources (
>    EdkIIRedfishResourceSetConfigureLang (&UnifiedConfigureLangList);
> 
>    for (Index = 0; Index < UnifiedConfigureLangList.Count; Index++) {
> -    DEBUG ((DEBUG_INFO, "[%d] create ComputerSystem resource from: %s\n",
> UnifiedConfigureLangList.List[Index].Index,
> UnifiedConfigureLangList.List[Index].ConfigureLang));
> +    DEBUG ((DEBUG_MANAGEABILITY, "[%d] create ComputerSystem resource
> from: %s\n", UnifiedConfigureLangList.List[Index].Index,
> UnifiedConfigureLangList.List[Index].ConfigureLang));
>      ProvisioningComputerSystemResource (Private,
> UnifiedConfigureLangList.List[Index].Index,
> UnifiedConfigureLangList.List[Index].ConfigureLang);
>      FreePool (UnifiedConfigureLangList.List[Index].ConfigureLang);
>    }
> @@ -1470,9 +1470,9 @@ RedfishCheckResourceCommon (
>        continue;
>      }
> 
> -    DEBUG ((DEBUG_INFO, "%a, [%d] check attribute for: %s\n", __func__, Index,
> Property));
> +    DEBUG ((DEBUG_MANAGEABILITY, "%a, [%d] check attribute for: %s\n",
> __func__, Index, Property));
>      if (!MatchPropertyWithJsonContext (Property, Json)) {
> -      DEBUG ((DEBUG_INFO, "%a, property is missing: %s\n", __func__, Property));
> +      DEBUG ((DEBUG_MANAGEABILITY, "%a, property is missing: %s\n",
> __func__, Property));
>        Status = EFI_NOT_FOUND;
>      }
>    }
> diff --git
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx
> e.c
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx
> e.c
> index 64480a2199..49d065c98b 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx
> e.c
> +++
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx
> e.c
> @@ -40,7 +40,7 @@ RedfishResourceProvisioningResource (
>      return EFI_INVALID_PARAMETER;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "%a, provisioning in %s mode\n", __func__,
> (PostMode ? L"POST" : L"PATCH")));
> +  DEBUG ((DEBUG_MANAGEABILITY, "%a, provisioning in %s mode\n", __func__,
> (PostMode ? L"POST" : L"PATCH")));
> 
>    Private =
> REDFISH_RESOURCE_COMMON_PRIVATE_DATA_FROM_RESOURCE_PROTOCOL
> (This);
> 
> diff --git
> a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo
> llectionDxe.c
> b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo
> llectionDxe.c
> index cd73542303..3ba2529c9c 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo
> llectionDxe.c
> +++
> b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo
> llectionDxe.c
> @@ -50,7 +50,7 @@ HandleResource (
>      Status = EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Private-
> >InformationExchange);
>      if (EFI_ERROR (Status)) {
>        if (Status == EFI_UNSUPPORTED) {
> -        DEBUG ((DEBUG_INFO, "%a, \"%s\" is not handled by us\n", __func__, Uri));
> +        DEBUG ((DEBUG_MANAGEABILITY, "%a, \"%s\" is not handled by us\n",
> __func__, Uri));
>          return EFI_SUCCESS;
>        }
> 
> diff --git
> a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> index ad212cdc54..b743403623 100644
> --- a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> @@ -64,7 +64,7 @@ RedfishConsumeResourceCommon (
>      //
>      // No change
>      //
> -    DEBUG ((DEBUG_INFO, "%a, ETAG: %s has no change, ignore consume
> action\n", __func__, Private->Uri));
> +    DEBUG ((DEBUG_MANAGEABILITY, "%a, ETAG: %s has no change, ignore
> consume action\n", __func__, Private->Uri));
>      Status = EFI_ALREADY_STARTED;
>      goto ON_RELEASE;
>    }
> @@ -2240,7 +2240,7 @@ ProvisioningMemoryResources (
>    EdkIIRedfishResourceSetConfigureLang (&UnifiedConfigureLangList);
> 
>    for (Index = 0; Index < UnifiedConfigureLangList.Count; Index++) {
> -    DEBUG ((DEBUG_INFO, "[%d] create Memory resource from: %s\n",
> UnifiedConfigureLangList.List[Index].Index,
> UnifiedConfigureLangList.List[Index].ConfigureLang));
> +    DEBUG ((DEBUG_MANAGEABILITY, "[%d] create Memory resource from:
> %s\n", UnifiedConfigureLangList.List[Index].Index,
> UnifiedConfigureLangList.List[Index].ConfigureLang));
>      ProvisioningMemoryResource (Private,
> UnifiedConfigureLangList.List[Index].Index,
> UnifiedConfigureLangList.List[Index].ConfigureLang);
>      FreePool (UnifiedConfigureLangList.List[Index].ConfigureLang);
>    }
> @@ -2386,9 +2386,9 @@ RedfishCheckResourceCommon (
>        continue;
>      }
> 
> -    DEBUG ((DEBUG_INFO, "%a, [%d] check attribute for: %s\n", __func__, Index,
> Property));
> +    DEBUG ((DEBUG_MANAGEABILITY, "%a, [%d] check attribute for: %s\n",
> __func__, Index, Property));
>      if (!MatchPropertyWithJsonContext (Property, Json)) {
> -      DEBUG ((DEBUG_INFO, "%a, property is missing: %s\n", __func__, Property));
> +      DEBUG ((DEBUG_MANAGEABILITY, "%a, property is missing: %s\n",
> __func__, Property));
>        Status = EFI_NOT_FOUND;
>      }
>    }
> diff --git a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c
> b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c
> index 55e091ac8d..7878411849 100644
> --- a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c
> +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c
> @@ -40,7 +40,7 @@ RedfishResourceProvisioningResource (
>      return EFI_INVALID_PARAMETER;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "%a, provisioning in %s mode\n", __func__,
> (PostMode ? L"POST" : L"PATCH")));
> +  DEBUG ((DEBUG_MANAGEABILITY, "%a, provisioning in %s mode\n", __func__,
> (PostMode ? L"POST" : L"PATCH")));
> 
>    Private =
> REDFISH_RESOURCE_COMMON_PRIVATE_DATA_FROM_RESOURCE_PROTOCOL
> (This);
> 
> diff --git
> a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c
> b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c
> index b594f726d0..b94ff2e865 100644
> --- a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c
> +++ b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c
> @@ -50,7 +50,7 @@ HandleResource (
>      Status = EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Private-
> >InformationExchange);
>      if (EFI_ERROR (Status)) {
>        if (Status == EFI_UNSUPPORTED) {
> -        DEBUG ((DEBUG_INFO, "%a, \"%s\" is not handled by us\n", __func__, Uri));
> +        DEBUG ((DEBUG_MANAGEABILITY, "%a, \"%s\" is not handled by us\n",
> __func__, Uri));
>          return EFI_SUCCESS;
>        }
> 
> diff --git
> a/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishResource
> ConfigLib.c
> b/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishResource
> ConfigLib.c
> index b5ef6e89b3..e7bd745e8b 100644
> ---
> a/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishResource
> ConfigLib.c
> +++
> b/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishResource
> ConfigLib.c
> @@ -129,7 +129,7 @@ GetSupportedSchemaVersion (
>      return Status;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "Supported schema: %a\n", SupportSchema));
> +  DEBUG ((DEBUG_MANAGEABILITY, "Supported schema: %a\n",
> SupportSchema));
> 
>    Index      = 0;
>    Found      = FALSE;
> diff --git
> a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
> b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
> index 00b6d70fed..1c9dec7e67 100644
> ---
> a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
> +++
> b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
> @@ -316,7 +316,7 @@ ApplyFeatureSettingsStringType (
>        //
>        // Apply settings from redfish
>        //
> -      DEBUG ((DEBUG_INFO, "%a, %a.%a apply %s from %a to %a\n", __func__,
> Schema, Version, ConfigureLang, RedfishValue.Value.Buffer, FeatureValue));
> +      DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a apply %s from %a to %a\n",
> __func__, Schema, Version, ConfigureLang, RedfishValue.Value.Buffer,
> FeatureValue));
> 
>        FreePool (RedfishValue.Value.Buffer);
>        RedfishValue.Value.Buffer = FeatureValue;
> @@ -377,7 +377,7 @@ ApplyFeatureSettingsNumericType (
>        //
>        // Apply settings from redfish
>        //
> -      DEBUG ((DEBUG_INFO, "%a, %a.%a apply %s from 0x%x to 0x%x\n",
> __func__, Schema, Version, ConfigureLang, RedfishValue.Value.Integer,
> FeatureValue));
> +      DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a apply %s from 0x%x to
> 0x%x\n", __func__, Schema, Version, ConfigureLang, RedfishValue.Value.Integer,
> FeatureValue));
> 
>        RedfishValue.Value.Integer = (INT64)FeatureValue;
> 
> @@ -437,7 +437,7 @@ ApplyFeatureSettingsBooleanType (
>        //
>        // Apply settings from redfish
>        //
> -      DEBUG ((DEBUG_INFO, "%a, %a.%a apply %s from %a to %a\n", __func__,
> Schema, Version, ConfigureLang, (RedfishValue.Value.Boolean ? "True" : "False"),
> (FeatureValue ? "True" : "False")));
> +      DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a apply %s from %a to %a\n",
> __func__, Schema, Version, ConfigureLang, (RedfishValue.Value.Boolean ?
> "True" : "False"), (FeatureValue ? "True" : "False")));
> 
>        RedfishValue.Value.Boolean = FeatureValue;
> 
> @@ -556,7 +556,7 @@ ApplyFeatureSettingsVagueType (
>            //
>            // Apply settings from redfish
>            //
> -          DEBUG ((DEBUG_INFO, "%a, %a.%a apply %s from %a to %a\n", __func__,
> Schema, Version, ConfigureKeyLang, RedfishValue.Value.Buffer,
> CurrentVagueValuePtr->Value->DataValue.CharPtr));
> +          DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a apply %s from %a to
> %a\n", __func__, Schema, Version, ConfigureKeyLang, RedfishValue.Value.Buffer,
> CurrentVagueValuePtr->Value->DataValue.CharPtr));
>            FreePool (RedfishValue.Value.Buffer);
>            RedfishValue.Value.Buffer = CurrentVagueValuePtr->Value-
> >DataValue.CharPtr;
>            Status                    = RedfishPlatformConfigSetValue (Schema, Version,
> ConfigureKeyLang, RedfishValue);
> @@ -564,7 +564,7 @@ ApplyFeatureSettingsVagueType (
>              DEBUG ((DEBUG_ERROR, "%a, apply %a to %a failed: %r\n", __func__,
> ConfigureKeyLang, CurrentVagueValuePtr->Value->DataValue.CharPtr, Status));
>            }
>          } else {
> -          DEBUG ((DEBUG_INFO, "%a, %a.%a %s value is: %a\n", __func__, Schema,
> Version, ConfigureKeyLang, RedfishValue.Value.Buffer, Status));
> +          DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a %s value is: %a\n",
> __func__, Schema, Version, ConfigureKeyLang, RedfishValue.Value.Buffer,
> Status));
>          }
>        } else if (PropertyDatatype == REDFISH_VALUE_TYPE_BOOLEAN) {
>          //
> @@ -575,7 +575,7 @@ ApplyFeatureSettingsVagueType (
>            // Apply settings from redfish
>            //
>            DEBUG ((
> -            DEBUG_INFO,
> +            DEBUG_MANAGEABILITY,
>              "%a, %a.%a apply %s from %a to %a\n",
>              __func__,
>              Schema,
> @@ -591,7 +591,7 @@ ApplyFeatureSettingsVagueType (
>              DEBUG ((DEBUG_ERROR, "%a, apply %s to %a failed: %r\n", __func__,
> ConfigureKeyLang, (*CurrentVagueValuePtr->Value->DataValue.BoolPtr ? "True" :
> "False"), Status));
>            }
>          } else {
> -          DEBUG ((DEBUG_INFO, "%a, %a.%a %s value is: %a\n", __func__, Schema,
> Version, ConfigureKeyLang, (RedfishValue.Value.Boolean ? "True" : "False"),
> Status));
> +          DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a %s value is: %a\n",
> __func__, Schema, Version, ConfigureKeyLang, (RedfishValue.Value.Boolean ?
> "True" : "False"), Status));
>          }
>        } else if (PropertyDatatype == REDFISH_VALUE_TYPE_INTEGER) {
>          //
> @@ -601,7 +601,7 @@ ApplyFeatureSettingsVagueType (
>            //
>            // Apply settings from redfish
>            //
> -          DEBUG ((DEBUG_INFO, "%a, %a.%a apply %s from 0x%x to 0x%x\n",
> __func__, Schema, Version, ConfigureKeyLang, RedfishValue.Value.Integer,
> *CurrentVagueValuePtr->Value->DataValue.Int64Ptr));
> +          DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a apply %s from 0x%x to
> 0x%x\n", __func__, Schema, Version, ConfigureKeyLang,
> RedfishValue.Value.Integer, *CurrentVagueValuePtr->Value-
> >DataValue.Int64Ptr));
> 
>            RedfishValue.Value.Integer = (INT64)*CurrentVagueValuePtr->Value-
> >DataValue.Int64Ptr;
>            Status                     = RedfishPlatformConfigSetValue (Schema, Version,
> ConfigureKeyLang, RedfishValue);
> @@ -609,7 +609,7 @@ ApplyFeatureSettingsVagueType (
>              DEBUG ((DEBUG_ERROR, "%a, apply %s to 0x%x failed: %r\n", __func__,
> ConfigureKeyLang, *CurrentVagueValuePtr->Value->DataValue.Int64Ptr, Status));
>            }
>          } else {
> -          DEBUG ((DEBUG_INFO, "%a, %a.%a %s value is: 0x%x\n", __func__,
> Schema, Version, ConfigureKeyLang, RedfishValue.Value.Integer, Status));
> +          DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a %s value is: 0x%x\n",
> __func__, Schema, Version, ConfigureKeyLang, RedfishValue.Value.Integer,
> Status));
>          }
>        } else {
>          DEBUG ((DEBUG_ERROR, "%a, %a.%a %s Unsupported Redfish property
> data type\n", __func__, Schema, Version, ConfigureLang));
> @@ -744,7 +744,7 @@ ApplyFeatureSettingsStringArrayType (
>        //
>        // Apply settings from redfish
>        //
> -      DEBUG ((DEBUG_INFO, "%a, %a.%a apply %s for array\n", __func__, Schema,
> Version, ConfigureLang));
> +      DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a apply %s for array\n",
> __func__, Schema, Version, ConfigureLang));
>        FreeArrayTypeRedfishValue (&RedfishValue);
> 
>        //
> @@ -842,7 +842,7 @@ ApplyFeatureSettingsNumericArrayType (
>        //
>        // Apply settings from redfish
>        //
> -      DEBUG ((DEBUG_INFO, "%a, %a.%a apply %s for array\n", __func__, Schema,
> Version, ConfigureLang));
> +      DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a apply %s for array\n",
> __func__, Schema, Version, ConfigureLang));
>        FreeArrayTypeRedfishValue (&RedfishValue);
> 
>        //
> @@ -935,7 +935,7 @@ ApplyFeatureSettingsBooleanArrayType (
>        //
>        // Apply settings from redfish
>        //
> -      DEBUG ((DEBUG_INFO, "%a, %a.%a apply %s for array\n", __func__, Schema,
> Version, ConfigureLang));
> +      DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a apply %s for array\n",
> __func__, Schema, Version, ConfigureLang));
>        FreeArrayTypeRedfishValue (&RedfishValue);
> 
>        //
> diff --git a/RedfishClientPkg/PrivateLibrary/RedfishLib/RedfishLib.c
> b/RedfishClientPkg/PrivateLibrary/RedfishLib/RedfishLib.c
> index 87a9027c83..c00b15f6fd 100644
> --- a/RedfishClientPkg/PrivateLibrary/RedfishLib/RedfishLib.c
> +++ b/RedfishClientPkg/PrivateLibrary/RedfishLib/RedfishLib.c
> @@ -764,7 +764,7 @@ RedfishDumpJsonStringFractions (
>      return;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "JSON text:\n"));
> +  DEBUG ((DEBUG_MANAGEABILITY, "JSON text:\n"));
>    NextFraction = String;
>    StrLen       = AsciiStrLen (String);
>    if (StrLen == 0) {
> @@ -774,13 +774,13 @@ RedfishDumpJsonStringFractions (
>    for (Count = 0; Count < (StrLen / StringFractionSize); Count++) {
>      BackupChar                           = *(NextFraction + StringFractionSize);
>      *(NextFraction + StringFractionSize) = 0;
> -    DEBUG ((DEBUG_INFO, "%a", NextFraction));
> +    DEBUG ((DEBUG_MANAGEABILITY, "%a", NextFraction));
>      *(NextFraction + StringFractionSize) = BackupChar;
>      NextFraction                        += StringFractionSize;
>    }
> 
>    if ((StrLen % StringFractionSize) != 0) {
> -    DEBUG ((DEBUG_INFO, "%a\n\n", NextFraction));
> +    DEBUG ((DEBUG_MANAGEABILITY, "%a\n\n", NextFraction));
>    }
>  }
> 
> @@ -919,7 +919,7 @@ RedfishIsValidOdataType (
>      }
>    }
> 
> -  DEBUG ((DEBUG_INFO, "%a: This Odata type is not in the list.\n", __func__));
> +  DEBUG ((DEBUG_MANAGEABILITY, "%a: This Odata type is not in the list.\n",
> __func__));
>    return FALSE;
>  }
> 
> diff --git
> a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
> b/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
> index fce28fd2f6..a38bdfbea6 100644
> --- a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
> +++ b/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
> @@ -461,7 +461,7 @@ getUriFromServiceEx (
>      return NULL;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "libredfish: getUriFromServiceEx(): %a\n", url));
> +  DEBUG ((DEBUG_MANAGEABILITY, "libredfish: getUriFromServiceEx(): %a\n",
> url));
> 
>    //
>    // Step 1: Create HTTP request message with 4 headers:
> @@ -621,7 +621,7 @@ getUriFromService (
>      return NULL;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "libredfish: getUriFromService(): %a\n", url));
> +  DEBUG ((DEBUG_MANAGEABILITY, "libredfish: getUriFromService(): %a\n",
> url));
> 
>    //
>    // Step 1: Create HTTP request message with 4 headers:
> @@ -782,7 +782,7 @@ patchUriFromServiceEx (
>      return NULL;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "libredfish: patchUriFromService(): %a\n", url));
> +  DEBUG ((DEBUG_MANAGEABILITY, "libredfish: patchUriFromService(): %a\n",
> url));
> 
>    //
>    // Step 1: Create HTTP request message with 4 headers:
> @@ -855,7 +855,7 @@ patchUriFromServiceEx (
>      ret = NULL;
>      goto ON_EXIT;
>    } else if (Status == EFI_UNSUPPORTED) {
> -    DEBUG ((DEBUG_INFO, "No content coding for %a! Use raw data instead.\n",
> HTTP_CONTENT_ENCODING_GZIP));
> +    DEBUG ((DEBUG_MANAGEABILITY, "No content coding for %a! Use raw data
> instead.\n", HTTP_CONTENT_ENCODING_GZIP));
>      Status = HttpIoSetHeader (HttpIoHeader, "Content-Encoding",
> HTTP_CONTENT_ENCODING_IDENTITY);
>      ASSERT_EFI_ERROR (Status);
>    } else {
> @@ -965,7 +965,7 @@ patchUriFromService (
>      return NULL;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "libredfish: patchUriFromService(): %a\n", url));
> +  DEBUG ((DEBUG_MANAGEABILITY, "libredfish: patchUriFromService(): %a\n",
> url));
> 
>    //
>    // Step 1: Create HTTP request message with 4 headers:
> @@ -1038,7 +1038,7 @@ patchUriFromService (
>      ret = NULL;
>      goto ON_EXIT;
>    } else if (Status == EFI_UNSUPPORTED) {
> -    DEBUG ((DEBUG_INFO, "No content coding for %a! Use raw data instead.\n",
> HTTP_CONTENT_ENCODING_GZIP));
> +    DEBUG ((DEBUG_MANAGEABILITY, "No content coding for %a! Use raw data
> instead.\n", HTTP_CONTENT_ENCODING_GZIP));
>      Status = HttpIoSetHeader (HttpIoHeader, "Content-Encoding",
> HTTP_CONTENT_ENCODING_IDENTITY);
>      ASSERT_EFI_ERROR (Status);
>    } else {
> @@ -1149,7 +1149,7 @@ postUriFromServiceEx (
>      return NULL;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "libredfish: postUriFromService(): %a\n", url));
> +  DEBUG ((DEBUG_MANAGEABILITY, "libredfish: postUriFromService(): %a\n",
> url));
> 
>    if (contentLength == 0) {
>      contentLength = strlen (content);
> @@ -1340,7 +1340,7 @@ postUriFromService (
>      return NULL;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "libredfish: postUriFromService(): %a\n", url));
> +  DEBUG ((DEBUG_MANAGEABILITY, "libredfish: postUriFromService(): %a\n",
> url));
> 
>    if (contentLength == 0) {
>      contentLength = strlen (content);
> @@ -1522,7 +1522,7 @@ deleteUriFromService (
>      return NULL;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "libredfish: deleteUriFromService(): %a\n", url));
> +  DEBUG ((DEBUG_MANAGEABILITY, "libredfish: deleteUriFromService(): %a\n",
> url));
> 
>    //
>    // Step 1: Create HTTP request message with 4 headers:
> diff --git
> a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c
> b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c
> index 2c16b78280..fbdb212c4a 100644
> --- a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c
> +++ b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c
> @@ -237,17 +237,17 @@ DumpConfigLangMapList (
>    }
> 
>    if (IsListEmpty (&ConfigLangMapList->Listheader)) {
> -    DEBUG ((DEBUG_INFO, "ConfigLangMap list is empty\n"));
> +    DEBUG ((DEBUG_MANAGEABILITY, "ConfigLangMap list is empty\n"));
>      return EFI_NOT_FOUND;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "Count: %d Total Size: %d\n", ConfigLangMapList-
> >Count, ConfigLangMapList->TotalSize));
> +  DEBUG ((DEBUG_MANAGEABILITY, "Count: %d Total Size: %d\n",
> ConfigLangMapList->Count, ConfigLangMapList->TotalSize));
>    Record = NULL;
>    List   = GetFirstNode (&ConfigLangMapList->Listheader);
>    while (!IsNull (&ConfigLangMapList->Listheader, List)) {
>      Record = REDFISH_CONFIG_LANG_MAP_RECORD_FROM_LIST (List);
> 
> -    DEBUG ((DEBUG_INFO, "ConfigLang: %s Uri: %s Size: %d\n", Record-
> >ConfigLang, Record->Uri, Record->Size));
> +    DEBUG ((DEBUG_MANAGEABILITY, "ConfigLang: %s Uri: %s Size: %d\n",
> Record->ConfigLang, Record->Uri, Record->Size));
> 
>      List = GetNextNode (&ConfigLangMapList->Listheader, List);
>    }
> @@ -787,7 +787,7 @@ RedfishConfigLangMapDriverEntryPoint (
>    //
>    Status = InitialConfigLangMapList (&mRedfishConfigLangMapPrivate-
> >ConfigLangList, mRedfishConfigLangMapPrivate->VariableName);
>    if (EFI_ERROR (Status)) {
> -    DEBUG ((DEBUG_INFO, "%a, Initial ConfigLangMap List: %r\n", __func__,
> Status));
> +    DEBUG ((DEBUG_MANAGEABILITY, "%a, Initial ConfigLangMap List: %r\n",
> __func__, Status));
>    }
> 
>    //
> diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c
> b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c
> index 7d611048e6..60ab473fd4 100644
> --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c
> +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c
> @@ -225,17 +225,17 @@ DumpETagList (
>    }
> 
>    if (IsListEmpty (&ETagList->Listheader)) {
> -    DEBUG ((DEBUG_INFO, "ETag list is empty\n"));
> +    DEBUG ((DEBUG_MANAGEABILITY, "ETag list is empty\n"));
>      return EFI_NOT_FOUND;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "Count: %d Total Size: %d\n", ETagList->Count,
> ETagList->TotalSize));
> +  DEBUG ((DEBUG_MANAGEABILITY, "Count: %d Total Size: %d\n", ETagList-
> >Count, ETagList->TotalSize));
>    Record = NULL;
>    List   = GetFirstNode (&ETagList->Listheader);
>    while (!IsNull (&ETagList->Listheader, List)) {
>      Record = REDFISH_ETAG_RECORD_FROM_LIST (List);
> 
> -    DEBUG ((DEBUG_INFO, "ETag: %a Uri: %a Size: %d\n", Record->ETag, Record-
> >Uri, Record->Size));
> +    DEBUG ((DEBUG_MANAGEABILITY, "ETag: %a Uri: %a Size: %d\n", Record-
> >ETag, Record->Uri, Record->Size));
> 
>      List = GetNextNode (&ETagList->Listheader, List);
>    }
> @@ -759,7 +759,7 @@ RedfishETagDriverEntryPoint (
>    //
>    Status = InitialETagList (&mRedfishETagPrivate->ETagList, mRedfishETagPrivate-
> >VariableName);
>    if (EFI_ERROR (Status)) {
> -    DEBUG ((DEBUG_INFO, "%a, Initial ETag List: %r\n", __func__, Status));
> +    DEBUG ((DEBUG_MANAGEABILITY, "%a, Initial ETag List: %r\n", __func__,
> Status));
>    }
> 
>    return EFI_SUCCESS;
> --
> 2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105500): https://edk2.groups.io/g/devel/message/105500
Mute This Topic: https://groups.io/mt/99215554/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list