[edk2-devel] [PATCH v2] MinPlatformPkg: Fix/Update code design gap.

[Susovan Mohapatra]

https://bugzilla.tianocore.org/show_bug.cgi?id=4461
1. The function GetRandomNumber128() returns a boolean TRUE/FALSE.
   The existing code was getting data in EFI_STATUS.0==FALSE==EFI_SUCCESS
   Updated code to check for the return value before proceeding further.
2. The 'seed' from the GetRandomNumber128() is in bits.
   Changed the copymem to the way it is done in other place in same code.

Cc: Chasel Chiu <chasel.chiu at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Isaac Oram <isaac.w.oram at intel.com>
Cc: Liming Gao <gaoliming at byosoft.com.cn>
Cc: Eric Dong <eric.dong at intel.com>

Signed-off-by: Susovan Mohapatra <susovan.mohapatra at intel.com>
---
 .../PeiDxeTpmPlatformHierarchyLib.c                      | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c b/Platform/Intel/MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c
index 9812ab99ab..0c18c74028 100644
--- a/Platform/Intel/MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c
+++ b/Platform/Intel/MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c
@@ -61,11 +61,10 @@ RdRandGenerateEntropy (
   // Generate high-quality seed for DRBG Entropy
   //
   while (BlockCount > 0) {
-    Status = GetRandomNumber128 (Seed);
-    if (EFI_ERROR (Status)) {
-      return Status;
+    if (!(GetRandomNumber128(Seed))) {
+      return EFI_DEVICE_ERROR;
     }
-    CopyMem (Ptr, Seed, 64);
+    CopyMem (Ptr, Seed, (Length % 64));
 
     BlockCount--;
     Ptr = Ptr + 64;
@@ -78,7 +77,7 @@ RdRandGenerateEntropy (
   if (EFI_ERROR (Status)) {
     return Status;
   }
-  CopyMem (Ptr, Seed, (Length % 64));
+  CopyMem (Ptr, Seed, 64);
 
   return Status;
 }
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109362): https://edk2.groups.io/g/devel/message/109362
Mute This Topic: https://groups.io/mt/101792759/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-