回复: [edk2-devel] [PATCH 1/1] BaseTools: trim warning to error

[gaoliming via groups.io]

Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 Yuwei Chen
> 发送时间: 2023年9月22日 14:47
> 收件人: devel at edk2.groups.io
> 抄送: Rebecca Cran <rebecca at bsdio.com>; Liming Gao
> <gaoliming at byosoft.com.cn>; Bob Feng <bob.c.feng at intel.com>
> 主题: [edk2-devel] [PATCH 1/1] BaseTools: trim warning to error
> 
> As the error is changed to warning, Trim.py will skip the build
> error when the source code have exactly issue.
> This patch change warning to error to opens the checking.
> 
> Cc: Rebecca Cran <rebecca at bsdio.com>
> Cc: Liming Gao <gaoliming at byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng at intel.com>
> Signed-off-by: Yuwei Chen <yuwei.chen at intel.com>
> ---
>  BaseTools/Source/Python/Trim/Trim.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/Trim/Trim.py
> b/BaseTools/Source/Python/Trim/Trim.py
> index c479f7d2b2e7..416935df5e90 100644
> --- a/BaseTools/Source/Python/Trim/Trim.py
> +++ b/BaseTools/Source/Python/Trim/Trim.py
> @@ -281,10 +281,10 @@ def DoInclude(Source, Indent='', IncludePathList=[],
> LocalSearchPath=None, Inclu
>                          F = File.readlines()
>                  break
>          else:
> -            EdkLogger.warn("Trim", "Failed to find include file %s" %
> Source)
> +            EdkLogger.error("Trim", "Failed to find include file %s" %
> Source)
>              return []
>      except:
> -        EdkLogger.warn("Trim", FILE_OPEN_FAILURE, ExtraData=Source)
> +        EdkLogger.error("Trim", FILE_OPEN_FAILURE, ExtraData=Source)
>          return []
> 
> 
> --
> 2.27.0.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109969): https://edk2.groups.io/g/devel/message/109969
Mute This Topic: https://groups.io/mt/102149316/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-