[edk2-devel] [edk2-platforms PATCH 0/7] drop needless init steps in RealTimeClockLib instances

Laszlo Ersek lersek at redhat.com
Tue Oct 24 13:20:56 UTC 2023


On 10/20/23 14:18, Laszlo Ersek wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=4565
> 
> RealTimeClockLib instances should neither set gRT fields nor install
> EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL in LibRtcInitialize();
> EmbeddedPkg/RealTimeClockRuntimeDxe already performs those actions.
> 
> Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> Cc: Bibo Mao <maobibo at loongson.cn>
> Cc: Chao Li <lichao at loongson.cn>
> Cc: Leif Lindholm <quic_llindhol at quicinc.com>
> Cc: Ling Jia <jialing at phytium.com.cn>
> Cc: Marcin Wojtas <mw at semihalf.com>
> Cc: Peng Xie <xiepeng at phytium.com.cn>
> Cc: Wenyi Xie <xiewenyi2 at huawei.com>
> Cc: Xianglai li <lixianglai at loongson.cn>
> Cc: Yiqi Shu <shuyiqi at phytium.com.cn>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (7):
>   Hisilicon/DS3231RealTimeClockLib: remove superfluous instance init
>     steps
>   LoongArchQemuPkg/LsRealTimeClockLib: remove superfluous instance init
>     steps
>   Hisilicon/M41T83RealTimeClockLib: remove superfluous instance init
>     steps
>   Hisilicon/RX8900RealTimeClockLib: remove superfluous instance init
>     steps
>   Silicon/Marvell/RealTimeClockLib: remove superfluous instance init
>     steps
>   FT2000-4Pkg/RealTimeClockLib: remove superfluous instance init steps
>   Omap35xxPkg/RealTimeClockLib: remove superfluous instance init steps
> 
>  Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.c       | 27 +++-----------------
>  Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c   | 16 ------------
>  Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.inf |  3 ---
>  Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.c            |  7 -----
>  Silicon/Hisilicon/Library/RX8900RealTimeClockLib/RX8900RealTimeClockLib.c            | 24 +++--------------
>  Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c               | 19 +-------------
>  Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c              | 13 ----------
>  Silicon/TexasInstruments/Omap35xxPkg/Library/RealTimeClockLib/RealTimeClockLib.c     | 19 +-------------
>  8 files changed, 8 insertions(+), 120 deletions(-)

Commit range fdbe20318f27..b68199ec5895.

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110007): https://edk2.groups.io/g/devel/message/110007
Mute This Topic: https://groups.io/mt/102079655/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3943202/1813853/130120423/xyzzy [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list