[edk2-devel] [PATCH v3 21/26] OvmfPkg: Enable Choosing Memory Protection Profile via QemuCfg

[Gerd Hoffmann]

  Hi,

>  .../PeilessStartupLib/PeilessStartup.c        | 60 +++++++++++++--
>  OvmfPkg/PlatformPei/Platform.c                | 74 +++++++++++++------

Can we move that code to a library so we don't add it twice to the code
base and also make it easier to reuse it for ArmVirtQemu?

See OvmfPkg/Library/TlsAuthConfigLib for example.

> +RETURN_STATUS
> +EFIAPI
> +QemuFwCfgParseString (
> +  IN     CONST CHAR8  *FileName,
> +  IN OUT UINTN        *BufferSize,
> +  OUT    CHAR8        *Buffer
> +  )
> +{
> +  return QemuFwCfgGetAsString (FileName, BufferSize, Buffer);
> +}

Separate patch please.

> -  gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack

Dropping that PCD can also go to a separate patch.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108484): https://edk2.groups.io/g/devel/message/108484
Mute This Topic: https://groups.io/mt/101064096/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-