[edk2-devel] [PATCH 0/2] ArmPkg/ArmVirtPkg: handle FEAT_VHE NS-EL2 virtual timer

Leif Lindholm quic_llindhol at quicinc.com
Tue Sep 19 15:19:38 UTC 2023


On 2023-09-19 14:18, Peter Maydell wrote:
> On Tue, 19 Sept 2023 at 12:20, Leif Lindholm <quic_llindhol at quicinc.com> wrote:
>>
>> An ASSERT trips when we try to add the NS-EL2 virtual timer to qemu
>> mach-virt.
>>
>> Add a new Pcd for the new private peripheral interrupt id,
>> PcdArmArchTimerHypVirtIntrNum.
>>
>> Update ArmVirtTimerFdtClientLib to:
>> - Only assert on receiving less information that required through DT.
>> - Set PcdArmArchTimerHypVirtIntrNum if provided through DT.
>>
>> Reported-by: Peter Maydell <peter.maydell at linaro.org>
>> Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
>> Cc: Sami Mujawar <sami.mujawar at arm.com>
> 
> Thanks for writing and sending out these patches. I've tested, and
> they are sufficient to get EDK2 to not assert and successfully
> boot a guest OS when using my QEMU RFC patchset that reports the
> new interrupt ID via the dtb:
> https://patchew.org/QEMU/20230919101240.2569334-1-peter.maydell@linaro.org/

Are you happy for me to interpret that as Tested-by for 2/2? (1/2 just 
being internal plumbing not related to preventing the ASSERT)

/
     Leif




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108849): https://edk2.groups.io/g/devel/message/108849
Mute This Topic: https://groups.io/mt/101453745/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3943202/1813853/130120423/xyzzy [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list