[edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

Sat Sep 30 17:35:05 UTC 2023

[AMD Official Use Only - General]

It looks good to me.

Reviewed-by:  Zhai MingXin<duke.zhai at amd.com>

Thanks!
Duke Zhai

-----Original Message-----
From: Chang, Abner <Abner.Chang at amd.com>
Sent: Saturday, September 30, 2023 12:18 AM
To: Leif Lindholm <quic_llindhol at quicinc.com>; devel at edk2.groups.io
Cc: Xing, Eric <Eric.Xing at amd.com>; Michael D Kinney <michael.d.kinney at intel.com>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar at amd.com>; Zhai, MingXin (Duke) <duke.zhai at amd.com>
Subject: RE: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

[AMD Official Use Only - General]

> -----Original Message-----
> From: Leif Lindholm <quic_llindhol at quicinc.com>
> Sent: Friday, September 29, 2023 11:31 PM
> To: devel at edk2.groups.io; Chang, Abner <Abner.Chang at amd.com>
> Cc: Xing, Eric <Eric.Xing at amd.com>; Michael D Kinney
> <michael.d.kinney at intel.com>; Attar, AbdulLateef (Abdul Lateef)
> <AbdulLateef.Attar at amd.com>; Zhai, MingXin (Duke) <duke.zhai at amd.com>
> Subject: Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh
> Silicon initialization firmware binaries 1/2] Maintainers.txt: Add
> maintainer for Silicon/AMD and Silicon/AMD/Vangogh
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Fri, Sep 29, 2023 at 14:52:23 +0000, Chang, Abner via groups.io wrote:
> > > -----Original Message-----
> > > From: Leif Lindholm <quic_llindhol at quicinc.com>
> > > Sent: Friday, September 29, 2023 6:49 PM
> > > To: Chang, Abner <Abner.Chang at amd.com>
> > > Cc: Xing, Eric <Eric.Xing at amd.com>; devel at edk2.groups.io; Michael
> > > D
> Kinney
> > > <michael.d.kinney at intel.com>; Attar, AbdulLateef (Abdul Lateef)
> > > <AbdulLateef.Attar at amd.com>
> > > Subject: Re: [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon
> > > initialization firmware binaries 1/2] Maintainers.txt: Add
> > > maintainer for Silicon/AMD and Silicon/AMD/Vangogh
> > >
> > > Caution: This message originated from an External Source. Use
> > > proper
> caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > Hi Abner,
> > >
> > > On Fri, Sep 29, 2023 at 09:09:25 +0000, Chang, Abner wrote:
> > > > We have done the review on these patches.
> > >
> > > Still waiting for an R-b from Duke. Hmm, who doesn't seem to have
> > > been cc:d.
> >
> > Hmm... he is not in CCed. I add him in CC. Lets just wait for his
> > RB, it  may take a while as China is in a long holiday. I will that
> > him know as well.
>
> Thanks.
>
> > > > Are you the steward of this repo and able to grant AMD folks the
> > > > merge privilege? To Eric, Abdul and me.
> > >
> > > I'm not a github admin - Mike?
> >
> > I thought you can do anything!! :-D
>
> Haha, thankfully not.
>
> > > But that reminds me, we should start adding github IDs in []
> > > brackets after email, like we do for edk2/edk2-platforms.
> >
> > I don’t quite understand. Any example?
>
> Ah, I'm getting ahead of myself - we haven't done that for
> edk2-platform yet, but:
>
> https://github.com/tianocore/edk2/blob/master/Maintainers.txt#L196
Ah, I got your point.

>
> > > > Btw, do we have to create a PR against non OSI repo for merging
> > > > or we can just push it?
> > >
> > > Just push. But send out for review first.
> >
> > Ok.
> >
> > >
> > > Are any of you attending the plugfest?
> > > If more maintainers are joining edk2-non-osi, maybe we should have
> > > a proper chat about it.
> >
> > I am checking now, I am not able to join this time though. But I
> > prefer you come to Taipei if there is an UEFI Plugfest in Taipei. 😊
>
> But will there be kaoliang? ;)
Absolutely, I will prepare one bottle for you if you come,  58% one for you. 😊

Abner

>
> Regards,
>
> Leif
>
> >
> > Abner
> >
> > >
> > > Regards,
> > >
> > > Leif
> > >
> > > > Get Outlook for Android<https://aka.ms/AAb9ysg>
> > > > ________________________________
> > > > From: Leif Lindholm <quic_llindhol at quicinc.com>
> > > > Sent: Friday, September 29, 2023 1:39:07 AM
> > > > To: Xing, Eric <Eric.Xing at amd.com>
> > > > Cc: devel at edk2.groups.io <devel at edk2.groups.io>; Michael D
> > > > Kinney
> > > <michael.d.kinney at intel.com>; Attar, AbdulLateef (Abdul Lateef)
> > > <AbdulLateef.Attar at amd.com>; Chang, Abner <Abner.Chang at amd.com>
> > > > Subject: Re: [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon
> > > initialization firmware binaries 1/2] Maintainers.txt: Add
> > > maintainer for Silicon/AMD and Silicon/AMD/Vangogh
> > > >
> > > > Caution: This message originated from an External Source. Use
> > > > proper
> > > caution when opening attachments, clicking links, or responding.
> > > >
> > > >
> > > > Hi Eric,
> > > >
> > > > Thanks.
> > > > You didn't really need to rework the patch, but I do want to see
> > > > the Reviewed-by's from the other added people before merging.
> > > >
> > > > Best Regards,
> > > >
> > > > Leif
> > > >
> > > > On Thu, Sep 28, 2023 at 17:13:36 +0000, Xing, Eric wrote:
> > > > > [AMD Official Use Only - General]
> > > > >
> > > > > Thanks Leif for your quick response and reminder. I added
> > > > > Abner as CC
> in
> > > PATCH v2.
> > > > > Sorry troubling you, would you help review it again so I can
> > > > > get your
> > > approved with v2 patch? Thanks again.
> > > > >
> > > > > Eric
> > > > >
> > > > > -----Original Message-----
> > > > > From: Leif Lindholm <quic_llindhol at quicinc.com>
> > > > > Sent: Friday, September 29, 2023 12:15 AM
> > > > > To: Xing, Eric <Eric.Xing at amd.com>
> > > > > Cc: devel at edk2.groups.io; Michael D Kinney
> > > <michael.d.kinney at intel.com>; Attar, AbdulLateef (Abdul Lateef)
> > > <AbdulLateef.Attar at amd.com>
> > > > > Subject: Re: [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh
> > > > > Silicon
> > > initialization firmware binaries 1/2] Maintainers.txt: Add
> > > maintainer for Silicon/AMD and Silicon/AMD/Vangogh
> > > > >
> > > > > Caution: This message originated from an External Source. Use
> > > > > proper
> > > caution when opening attachments, clicking links, or responding.
> > > > >
> > > > >
> > > > > +Abner
> > > > >
> > > > > Looks fine to me, but I'd like to have a Reviewed-by from
> > > > > Abner, Abdul,
> > > Duke.
> > > > >
> > > > > Best Regards,
> > > > >
> > > > > Leif
> > > > >
> > > > > On Thu, Sep 28, 2023 at 22:30:53 +0800, eric.xing at amd.com wrote:
> > > > > > From: Eric Xing <Eric.Xing at amd.com>
> > > > > >
> > > > > > Signed-off-by: Eric Xing <eric.xing at amd.com>
> > > > > > Cc: Michael D Kinney <michael.d.kinney at intel.com>
> > > > > > Cc: Leif Lindholm <quic_llindhol at quicinc.com>
> > > > > > Cc: Abdul Lateef Attar <abdattar at amd.com>
> > > > > > Signed-off-by: Eric Xing <Eric.Xing at amd.com>
> > > > > > ---
> > > > > >  Maintainers.txt | 9 +++++++++
> > > > > >  1 file changed, 9 insertions(+)
> > > > > >
> > > > > > diff --git a/Maintainers.txt b/Maintainers.txt index
> > > > > > c42d135..1d5dacb
> > > > > > 100644
> > > > > > --- a/Maintainers.txt
> > > > > > +++ b/Maintainers.txt
> > > > > > @@ -58,6 +58,15 @@ Platform/Intel/CometlakeSiliconBinPkg
> > > > > >  M: Kathappan Esakkithevar
> > > > > > <kathappan.esakkithevar at intel.com>
> > > > > >  M: Sai Chaganty <rangasai.v.chaganty at intel.com>
> > > > > >
> > > > > > +Silicon/AMD
> > > > > > +M: Abner Chang <abner.chang at amd.com>
> > > > > > +M: Abdul Lateef Attar <abdattar at amd.com>
> > > > > > +M: Eric Xing <eric.xing at amd.com>
> > > > > > +
> > > > > > +Silicon/AMD/Vangogh
> > > > > > +M: Duke Zhai <duke.zhai at amd.com>
> > > > > > +M: Eric Xing <eric.xing at amd.com>
> > > > > > +
> > > > > >  Silicon/Ampere/AmpereAltraBinPkg
> > > > > >  M: Nhi Pham <nhi at os.amperecomputing.com>
> > > > > >  M: Vu Nguyen <vunguyen at os.amperecomputing.com>
> > > > > > --
> > > > > > 2.17.1
> > > > > >
> >
> >
> > 
> >
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109286): https://edk2.groups.io/g/devel/message/109286
Mute This Topic: https://groups.io/mt/101638924/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-