<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="ZH-CN" link="blue" vlink="purple"> <div class="WordSection1"> Fish:<o:p></o:p> <a name="_MailEndCompose"><o:p> </o:p></a> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> <a name="_____replyseparator"></a>From: afish@apple.com [mailto:afish@apple.com] Sent: Thursday, June 6, 2019 11:39 AM To: devel@edk2.groups.io; Lu, XiaoyuX <xiaoyux.lu@intel.com> Cc: Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Wang, Jian J <jian.j.wang@intel.com> Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem<o:p></o:p> </div> </div> <o:p> </o:p> <o:p> </o:p> <div> <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> On Jun 4, 2019, at 11:33 PM, Xiaoyu Lu <<a href="mailto:xiaoyux.lu@intel.com">xiaoyux.lu@intel.com</a>> wrote:<o:p></o:p> </div> <o:p> </o:p> <div> Hi Liming, <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> -----Original Message----- From: Gao, Liming Sent: Wednesday, June 5, 2019 1:57 PM To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; Lu, XiaoyuX <<a href="mailto:xiaoyux.lu@intel.com">xiaoyux.lu@intel.com</a>> Cc: Bi, Dandan <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>>; Wang, Jian J <<a href="mailto:jian.j.wang@intel.com">jian.j.wang@intel.com</a>> Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem Xiaoyu: <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> -----Original Message----- From: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> [<a href="mailto:devel@edk2.groups.io">mailto:devel@edk2.groups.io</a>] On Behalf Of Xiaoyu Lu Sent: Wednesday, June 05, 2019 1:25 PM To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> Cc: Lu, XiaoyuX <<a href="mailto:xiaoyux.lu@intel.com">xiaoyux.lu@intel.com</a>>; Bi, Dandan<o:p></o:p> </blockquote> <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>>; <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Wang, Jian J <<a href="mailto:jian.j.wang@intel.com">jian.j.wang@intel.com</a>> Subject: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem When use clang-3.8 to build the NetworkPkg, compiler optimization may use memcpy for memory copy. For example: CryptoPkg/Library/OpensslLib/openssl/ssl/ssl_rsa.c:918: undefined reference to `memcpy'` Compiler optimization is sophisticated, but we can work around it use __attribute__((__used__)) to informs the compiler that symbol should be retained in the object file, even if it may be unreferenced. Cc: Jian J Wang <<a href="mailto:jian.j.wang@intel.com">jian.j.wang@intel.com</a>> Cc: Dandan Bi <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>> Signed-off-by: Xiaoyu Lu <<a href="mailto:xiaoyux.lu@intel.com">xiaoyux.lu@intel.com</a>> --- CryptoPkg/Library/IntrinsicLib/CopyMem.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/CryptoPkg/Library/IntrinsicLib/CopyMem.c b/CryptoPkg/Library/IntrinsicLib/CopyMem.c index e29b4918d200..7faf5a34d8c1 100644 --- a/CryptoPkg/Library/IntrinsicLib/CopyMem.c +++ b/CryptoPkg/Library/IntrinsicLib/CopyMem.c @@ -10,8 +10,21 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include <Base.h> #include <Library/BaseMemoryLib.h> +#if defined(__clang__) && !defined(__APPLE__)<o:p></o:p> </blockquote> So, this change is only for CLANG tool chain. <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> + +/* Copies bytes between buffers */ +static __attribute__((__used__))<o:p></o:p> </blockquote> What purpose for static?<o:p></o:p> </blockquote> Because I want __memcpy only use in this file scope. <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> +void * __memcpy (void *dest, const void *src, unsigned int count) +{ + return CopyMem (dest, src, (UINTN)count); +} +__attribute__((__alias__("__memcpy"))) +void * memcpy (void *dest, const void *src, unsigned int count);<o:p></o:p> </blockquote> __memcpy is IA32 Intrinsic API, memcpy is X64 Intrinsic API, right?<o:p></o:p> </blockquote> __memcpy isn't IA32 Intrinsic API, only memcpy is intrinsic API for both IA32 and X64. The reason I alias memcpy and use __attribute__((__used__)) is let compiler retain symbol in object file, So it can link correct. Is this correct? <o:p></o:p> </div> </blockquote> <div> <o:p> </o:p> </div> <div> I think this is a bug in clang that requires the __used__, we hit something like this with Xcode too. If the compiler emits the intrinsic it should tell the linker and some how that was getting missed. Thus the __used__ is a work around. <o:p></o:p> </div> <div> <o:p> </o:p> OK. It is for CLANG 3.8. I will check whether the latest CLANG8.0 fixes it. <o:p></o:p> <o:p> </o:p> </div> <div> Thanks,<o:p></o:p> </div> <div> <o:p> </o:p> </div> <div> Andrew Fish<o:p></o:p> </div> <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt;font-variant-caps: normal;orphans: auto;text-align:start;widows: auto;-webkit-text-size-adjust: auto;-webkit-text-stroke-width: 0px;word-spacing:0px"> <div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Thanks Liming<o:p></o:p> </blockquote> <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> + +#else /* Copies bytes between buffers */ void * memcpy (void *dest, const void *src, unsigned int count) { return CopyMem (dest, src, (UINTN)count); } +#endif -- 2.7.4 <o:p></o:p> </blockquote> </blockquote> <o:p></o:p> </div> </blockquote> </div> <o:p> </o:p> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/41975">View/Reply Online (#41975)</a> | | <a target="_blank" href="https://groups.io/mt/31934411/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>