<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72"> <div class="WordSection1"> HI Hao:<o:p></o:p> I don’t have extra comments for the whole patch<o:p></o:p> <a name="_MailEndCompose"><o:p> </o:p></a> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> <a name="_____replyseparator"></a>From: Wu, Hao A Sent: Wednesday, June 12, 2019 3:48 PM To: devel@edk2.groups.io; Xu, Wei6 <wei6.xu@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com> Cc: Wang, Jian J <jian.j.wang@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com> Subject: RE: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk.<o:p></o:p> </div> </div> <o:p> </o:p> Hello Chao, Do you have any comment/feedback on this series? One comment with regard to the series below: > -----Original Message----- > From: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> [<a href="mailto:devel@edk2.groups.io">mailto:devel@edk2.groups.io</a>] On Behalf Of > Xu, Wei6 > Sent: Wednesday, June 05, 2019 11:42 PM > To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> > Cc: Wang, Jian J; Wu, Hao A; Kinney, Michael D; Gao, Liming; Zhang, Chao B > Subject: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk. > > V2: > Fix Ecc check failure. > > V1: > BZ: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=1852">https://bugzilla.tianocore.org/show_bug.cgi?id=1852</a> > > This patch set implements Capsule On Disk. > Depends on whether platform supports Capsule-In-Ram, Capsule On Disk > feature is composed of 2 solutions: > Solution A): Load capsules out of TCB, rely on UpdateCapsule() runtime > service to deliver Capsule-On-Disk. > Solution B): Relocate capsules into a temp file which will be stored in root > directory on a platform specific storage device. > Leverage existing storage stack in PEI to load all capsule on disk images and > create capsule hobs for the capsules. > This solution has bigger TCB, but can work without Capsule-In-RAM support. > > > Cc: Jian J Wang <<a href="mailto:jian.j.wang@intel.com">jian.j.wang@intel.com</a>> > Cc: Hao A Wu <<a href="mailto:hao.a.wu@intel.com">hao.a.wu@intel.com</a>> > Cc: Michael D Kinney <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>> > Cc: Liming Gao <<a href="mailto:liming.gao@intel.com">liming.gao@intel.com</a>> > Cc: Chao B Zhang <<a href="mailto:chao.b.zhang@intel.com">chao.b.zhang@intel.com</a>> > > xuwei6 (7): > MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition. > MdeModulePkg: Add Capsule On Disk related definition. > MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM. > MdeModulePkg/BdsDxe: Support Capsule On Disk. > MdeModulePkg/CapsuleRuntimeDxe: Introduce PCD to control this feature. > MdeModulePkg/DxeIpl: Support Capsule On Disk. > MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib. Please re-order the sequence of the patches. I found that the below patch: MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM. depends on some definitions added in patch (last one): MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib. Best Regards, Hao Wu > > MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | 3 +- > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 20 +- > MdeModulePkg/Core/DxeIplPeim/DxeLoad.c | 37 +- > MdeModulePkg/Include/Library/CapsuleLib.h | 94 +- > MdeModulePkg/Include/Ppi/CapsuleOnDisk.h | 48 + > .../Library/DxeCapsuleLibFmp/CapsuleOnDisk.c | 1983 > ++++++++++++++++++++ > .../Library/DxeCapsuleLibFmp/CapsuleOnDisk.h | 63 + > .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 56 +- > .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf | 21 +- > .../DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 121 +- > .../Library/DxeCapsuleLibFmp/DxeCapsuleReportLib.c | 67 +- > .../DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 3 +- > .../Library/DxeCapsuleLibNull/DxeCapsuleLibNull.c | 85 +- > MdeModulePkg/MdeModulePkg.dec | 43 + > MdeModulePkg/MdeModulePkg.dsc | 4 + > MdeModulePkg/MdeModulePkg.uni | 32 + > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 3 +- > MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 6 +- > .../CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.c | 442 +++++ > .../CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.inf | 64 + > .../CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.uni | 15 + > .../CapsuleOnDiskLoadPeiExtra.uni | 14 + > .../CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf | 1 + > .../Universal/CapsuleRuntimeDxe/CapsuleService.c | 10 +- > MdePkg/Include/Ppi/BootInRecoveryMode.h | 9 +- > MdePkg/MdePkg.dec | 3 + > 26 files changed, 3205 insertions(+), 42 deletions(-) > create mode 100644 MdeModulePkg/Include/Ppi/CapsuleOnDisk.h > create mode 100644 > MdeModulePkg/Library/DxeCapsuleLibFmp/CapsuleOnDisk.c > create mode 100644 > MdeModulePkg/Library/DxeCapsuleLibFmp/CapsuleOnDisk.h > create mode 100644 > MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.c > create mode 100644 > MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.i > nf > create mode 100644 > MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.u > ni > create mode 100644 > MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPeiE > xtra.uni > > -- > 2.16.2.windows.1 > > > <o:p></o:p> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/42269">View/Reply Online (#42269)</a> | | <a target="_blank" href="https://groups.io/mt/31938573/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>